Use of http2 API from master node.core in express application

[uttampawar]

I'm trying to port https://github.com/Node-DC/Node-DC-EIS application (currently in node.js benchmarking) to use http2 api from Node.js core to track and understand performance impact of new api. I know how "spdy" module is used in express app, is this going to be similar? Or is there any guideline or migration document/readme available? What branch of express I should use for my work? This can also help test http2 support in express if that is something is important to expressjs project.

[dougwilson]

PR #3390 is the current work for http2 support, if that helps.

[uttampawar]

@dougwilson Thanks and yes, I'm following all the discussion on that thread. Since I'm newbie at JS development just wanted to get clarification about kind of changes I need to make to dc-eis application. For e.g. in this application we have following,

var express = require('express');
var app_host='localhost';
var app_port=9000;
var app = express();
var server = app.listen({ host: app_host, port: port});

I understand that above code (app.listen line) needs to change with something line,
var http2 = require('http2');
const server = http2.createSecureServer({
key: fs.readFileSync('localhost-privkey.pem'),
cert: fs.readFileSync('localhost-cert.pem')
}, app).listen(app_port, app_host);

But is that it?

[dougwilson]

Gotcha, sorry. Yes, that would work if you are using the code from that PR branch (not master). You can also check out the example app in that PR for a complete example: https://github.com/phouri/express/blob/2ac75f2ffa75bafc05e53b90d3bde8b02b6028ce/examples/http2/index.js

[uttampawar]

@dougwilson Thanks for the example PR.

[atdiff]

@dougwilson, any updates on when the PR will be released and the http2 functionality available?

[dougwilson]

Someone needs to complete that PR. I can do it too, but no one ever gave me the code they used so I could finish it. See my request in #3390 (comment)

If you have an idea for what my next step is, please let me know 👍

[atdiff]

@dougwilson Thanks for the update. No worries. Just curious and anxious to use it. :)

[Abourass]

@dougwilson - The thread you linked, you just closed. (That's how I found it). I think the following link is correct?

For those looking, here's the new PR under which to discuss this topic - #3730

[bjohansebas]

I'm going to close this to keep the HTTP2 conversation in #5462