Add a test for log

[lrettig]

Cf. ethereum#394: this is not currently possible with testeth but we should add something to test the log EEI method.

[axic]

Don't we have any tests for this? It seems that those lines are covered in Hera?

[axic]

@hugo-dc @lrettig ping

[lrettig]

We have tests for erroneous usage of log, but AFAIK no test for correct usage. This may be okay.

logTooManyTopicsFiller.yml
logTopicVeryLongFiller.yml
logTopicsOverflowFiller.yml
logVeryLongFiller.yml
logZeroLengthMemoryFiller.yml

[axic]

@hugo-dc @lrettig can we add tests for proper usage of log? Even if we cannot test the content is proper, at least the gas usage should be tested.

[lrettig]

Yup will take a look asap!

[axic]

Currently added tests (via #114):

• log1Topic: "Test log with 1 topic (other topics have invalid memory offsets)"
• logInvalidNumTopics: "test log with log with 5 topics (expect OOG)"
• logInvalidPtr: "test log with log with invalid topic pointer"
• logOOM: "test log with log data size too high (expect OOG)"
• logTopics: "Test log with multiple (3) topics"
• logZeroTopics: "Test log with zero topics" -- need to be fixed to actually contain 0 topics

Two more cases we could add:

• logNoData where the data length is 0 this exists as logZeroLengthMemory
• logNoDataHighOffset where the data length is 0, but the data offset is OOM - not sure what will happen, hence we need a test

[axic]

@jwasinger @hugo-dc can you add that single last tests, logNoDataHighOffset? It should have 0xffffffff for data offset, but 0 as data length.

I expect it to be successful, but if it fails we may need to adjust Hera.

[jwasinger]

Sure.