PR 423 merge conflicts resolved. Tests passing.

Author: owleyeview

.github/workflows/ci.yml

@@ -30,6 +30,10 @@ jobs:
         run: |
           nix develop --command bash -c "npm ci"
 
+      - name: Check SDK wire fixtures are up to date
+        run: |
+          nix develop --command bash -c "npm run regen:sdk-fixtures && git diff --exit-code host/map-sdk/tests/fixtures/"
+
       - name: Test
         run: |
           nix develop --command bash -c "npm test"

Cargo.lock

@@ -48,6 +48,8 @@ holons_guest_integrity = { path = "happ/crates/holons_guest_integrity" }
 #holochain_receptor = { path = "host/crates/holochain_receptor" }
 #holons_receptor = { path = "host/crates/holons_receptor" }
 #holons_loader_client = { path = "host/crates/holons_loader_client" }
+map_commands_contract = { path = "host/crates/map_commands_contract" }
+map_commands_runtime = { path = "host/crates/map_commands_runtime" }
 
 
 # Shared

Cargo.toml

@@ -46,10 +46,8 @@ impl Dancer {
         dispatch_table.insert("add_related_holons", add_related_holons_dance as DanceFunction);
         dispatch_table.insert("commit", commit_dance as DanceFunction);
         dispatch_table.insert("delete_holon", delete_holon_dance as DanceFunction);
-        dispatch_table.insert(
-            "fetch_all_related_holons",
-            fetch_all_related_holons_dance as DanceFunction,
-        );
+        dispatch_table
+            .insert("fetch_all_related_holons", fetch_all_related_holons_dance as DanceFunction);
         dispatch_table.insert("get_all_holons", get_all_holons_dance as DanceFunction);
         dispatch_table.insert("get_holon_by_id", get_holon_by_id_dance as DanceFunction);
         dispatch_table.insert("load_holons", load_holons_dance as DanceFunction);
@@ -107,9 +105,7 @@ impl Dancer {
 /// * `description` holds the error message associated with the HolonError
 /// * `body` and `descriptor` are set to None
 ///
-fn process_dispatch_result(
-    dispatch_result: Result<ResponseBody, HolonError>,
-) -> DanceResponse {
+fn process_dispatch_result(dispatch_result: Result<ResponseBody, HolonError>) -> DanceResponse {
     match dispatch_result {
         Ok(body) => DanceResponse {
             status_code: ResponseStatusCode::OK,

happ/crates/holons_guest/src/dances_guest/dancer.rs

@@ -445,8 +445,14 @@ fn commit_relationship(
     Ok(())
 }
 
-/// This method creates smartlinks from the specified source_id for the specified relationship name
-/// to each holon in its collection that has a holon_id.
+/// Creates SmartLinks from `source_id` to each member in `collection`.
+///
+/// Current behavior is fail-fast at the collection level: if any member cannot
+/// resolve a persisted `holon_id` or key metadata, this function returns that
+/// error immediately and no later members in the same collection are processed.
+/// In practice, an abandoned staged target can therefore prevent otherwise
+/// valid sibling links in the same relationship collection from being
+/// persisted during this commit pass.
 fn save_smartlinks_for_collection(
     _context: &Arc<TransactionContext>,
     source_id: LocalId,

happ/crates/holons_guest/src/guest_shared_objects/commit_functions.rs

@@ -1,6 +1,9 @@
 use std::any::Any;
 use std::collections::HashMap;
-use std::{fmt, sync::{Arc, RwLock}};
+use std::{
+    fmt,
+    sync::{Arc, RwLock},
+};
 
 use hdk::prelude::*;
 use holons_core::core_shared_objects::SavedHolon;
@@ -21,9 +24,7 @@ use base_types::MapString;
 use core_types::{HolonError, HolonId};
 use holons_core::core_shared_objects::transactions::TransactionContextHandle;
 use holons_core::{
-    core_shared_objects::{
-        transactions::TransactionContext, Holon, HolonCollection,
-    },
+    core_shared_objects::{transactions::TransactionContext, Holon, HolonCollection},
     reference_layer::{
         HolonCollectionApi, HolonReference, HolonServiceApi, SmartReference, WritableHolon,
     },

happ/crates/holons_guest/src/guest_shared_objects/guest_holon_service.rs

@@ -4,9 +4,7 @@ use base_types::{BaseValue, MapString};
 use core_types::{ExternalId, HolonError, HolonId, OutboundProxyId};
 use hdi::prelude::*;
 use hdk::prelude::*;
-use holons_core::{
-    core_shared_objects::holon::key_from_property_map,
-};
+use holons_core::core_shared_objects::holon::key_from_property_map;
 use holons_guest_integrity::type_conversions::*;
 use holons_integrity::LinkTypes;
 use holons_integrity::*;