Issue #228 / PR #243 deployed retest findings for a3b39dd

[eviltester]

Summary

This issue records the deployed-environment exploratory retest findings for story #228 and PR #243.

The retest bundle is stored locally in docs/testing/20260625/issue-228-001/ in the testing evidence repository. The test environment reviewed was https://eviltester.github.io/grid-table-editor/.

Full testing notes can be found here: https://github.com/eviltester/anywaydata-ai-testing/tree/main/docs/testing/20260625/issue-228-001

References

• Story: improve command definition #228
• PR: [codex] Refactor enum handling through domain commands #243
• Test environment: https://eviltester.github.io/grid-table-editor/
• Deployed branch: codex/228-improve-command-definition
• Deployed commit: a3b39ddcfe0f
• Deployed build: 2026-06-24T23:03:43.621Z
• Prior completed baseline: docs/testing/20260624/issue-228-002/ at commit fb9e8e2049e1 built 2026-06-24T20:13:50.037Z

Review Performed

The review used the deployed test environment only and completed multiple explicit exploratory loops, including the mandatory final review loop. Coverage included broad command-definition sampling, docs/examples comparison, negative validation, generator/app workflow checks, UX regression checks, responsive/mobile checks, and accessibility heuristics.

Subagent lanes used:

• Command coverage and example execution
• Negative validation and malformed parameter testing
• Docs/help/content consistency across app and published docs
• UX/usability and workflow regression in generator, method-picker, help, and related flows
• Responsive/mobile and accessibility review
• Enum canonicalization and syntax compatibility review

Headline Result

Positive command-definition behavior looked materially improved across many happy paths, including enum aliases, datatype.enum, compact enum lists, datatype.boolean, finance, commerce, date, number, science, system, autoIncrement, helpers.fake, schema import/export, app generation, and picker visibility.

However, the retest found medium-severity issues around validation, docs/runtime consistency, focus management, and accessible names. The recommendation from the report was not to treat the changes as fully acceptable yet until those defects are fixed or explicitly triaged.

Defect Comments

I am adding one comment per markdown defect file from docs/testing/20260625/issue-228-001/defects/. Each comment contains the full source text of the corresponding defect file.

• DEFECT-command-docs-location-cardinaldirection-abbreviated.md
• DEFECT-faker-doc-examples-do-not-execute.md
• docs-still-reference-generate-html.md
• faker-docs-helpers-mustache-example-rejected.md
• issue-228-app-icon-controls-missing-accessible-names.md
• issue-228-bad-enum-quote-generates-corrupted-values.md
• issue-228-boolean-probability-out-of-range-is-accepted.md
• issue-228-controls-missing-accessible-names.md
• issue-228-empty-or-missing-enum-values-have-weak-feedback.md
• issue-228-generator-schema-row-tab-order-trap.md
• issue-228-invalid-number-and-date-constraints-generate-error-rows.md
• issue-228-modal-focus-not-restored.md
• issue-228-unknown-enum-named-argument-is-accepted.md
• negative-validation-defects.md

[eviltester]

Defect file: DEFECT-command-docs-location-cardinaldirection-abbreviated.md

Full text from docs/testing/20260625/issue-228-001/defects/DEFECT-command-docs-location-cardinaldirection-abbreviated.md:

Defect: Domain overview documents invalid location.cardinalDirection(abbreviated=true) example

Summary

The public Domain Test Data overview shows a quick example using location.cardinalDirection(abbreviated=true), but the deployed generator rejects abbreviated for location.cardinalDirection. The location domain detail page documents location.cardinalDirection as having no parameters, and the equivalent parameterized command that works is location.direction(abbreviated=true).

Environment

• Deployed app: https://eviltester.github.io/grid-table-editor/generator.html
• Public docs: https://eviltester.github.io/grid-table-editor/site/docs/test-data/domain/domain-test-data/
• Public detail docs: https://eviltester.github.io/grid-table-editor/site/docs/test-data/domain/location/
• Branch shown by deployed landing page: codex/228-improve-command-definition
• Commit shown by deployed landing page: a3b39ddcfe0f
• Build shown by deployed landing page: 2026-06-24T23:03:43.621Z

Steps to Reproduce

1. Open https://eviltester.github.io/grid-table-editor/site/docs/test-data/domain/domain-test-data/.
2. Note the quick example:

Direction
location.cardinalDirection(abbreviated=true)

3. Open https://eviltester.github.io/grid-table-editor/generator.html.
4. Switch schema editor to Edit as Text.
5. Enter:

Direction
location.cardinalDirection(abbreviated=true)

6. Click Preview.

Actual Result

Preview fails with:

Row 1: invalid domain params - Invalid keyword arguments: unknown named argument "abbreviated"

Expected Result

Either the documented quick example should execute successfully, or the overview should use the valid command:

Direction
location.direction(abbreviated=true)

Control test:

Direction
location.direction(abbreviated=true)

This passed and generated abbreviated directions such as SW, N, W, NW, SE, and E.

Notes for Fix

The location detail page says location.cardinalDirection has no parameters and documents location.direction(abbreviated=true) as the parameterized abbreviated-direction example. The likely fix is to update the Domain Test Data overview quick example from location.cardinalDirection(abbreviated=true) to location.direction(abbreviated=true).

[eviltester]

Defect file: DEFECT-faker-doc-examples-do-not-execute.md

Full text from docs/testing/20260625/issue-228-001/defects/DEFECT-faker-doc-examples-do-not-execute.md:

Defect: Two public Faker Based Data examples do not execute in deployed generator

Summary

The public Faker Based Data docs page presents direct faker examples that appear intended to be executable schema examples. Two of those examples fail in the deployed generator:

• helpers.mustache("I found {{count}} instances.", { count: () => ${this.number.int()} })
• faker.location.cardinalDirection({ abbreviated: true })

The adjacent helpers.fake(...) example does execute successfully.

Environment

• Deployed app: https://eviltester.github.io/grid-table-editor/generator.html
• Public docs: https://eviltester.github.io/grid-table-editor/site/docs/test-data/faker-test-data/
• Branch shown by deployed landing page: codex/228-improve-command-definition
• Commit shown by deployed landing page: a3b39ddcfe0f
• Build shown by deployed landing page: 2026-06-24T23:03:43.621Z

Steps to Reproduce: helpers.mustache

1. Open https://eviltester.github.io/grid-table-editor/generator.html.
2. Switch schema editor to Edit as Text.
3. Enter the documented example:

Sentence
helpers.mustache("I found {{count}} instances.", { count: () => `${this.number.int()}` })

4. Click Preview.

Actual Result: helpers.mustache

Preview fails with:

Row 1: invalid faker params - Invalid Faker API Call Unsafe faker rule syntax detected: requires complex argument parsing

Steps to Reproduce: direct faker object parameter

1. Open https://eviltester.github.io/grid-table-editor/generator.html.
2. Switch schema editor to Edit as Text.
3. Enter the documented example:

Direction
faker.location.cardinalDirection({ abbreviated: true })

4. Click Preview.

Actual Result: direct faker object parameter

Preview fails with:

Row 1: invalid faker params - Invalid keyword arguments: too many positional arguments. Expected at most 0, received 1

Expected Result

Public docs examples that are presented as schema examples should execute successfully in the deployed generator, or the docs should be changed to supported schema syntax.

Control Example

The adjacent docs example below passed:

Sentence
helpers.fake("Hi, my name is {{person.firstName}} {{person.lastName}}!")

Observed output included rows such as:

Hi, my name is Marisa McLaughlin!

Notes for Fix

If object-literal/callback faker arguments are intentionally unsupported by the schema parser, the docs should avoid presenting them as executable schema examples. If direct faker examples should be executable, the parser/runtime needs support for these documented argument shapes or the docs should provide the equivalent supported named-argument/domain form.

[eviltester]

Defect file: docs-still-reference-generate-html.md

Full text from docs/testing/20260625/issue-228-001/defects/docs-still-reference-generate-html.md:

Published Docs Still Reference generate.html

Summary

Several published docs pages still describe the generator page as generate.html, but the deployed environment exposes generator.html. Both root and nested generate.html URLs return 404.

Environment

• Landing page: https://eviltester.github.io/grid-table-editor/
• Branch: codex/228-improve-command-definition
• Commit: a3b39ddcfe0f
• Build: 2026-06-24T23:03:43.621Z

Steps To Reproduce

1. Open https://eviltester.github.io/grid-table-editor/site/docs/test-data/test-data-generation.
2. Search the page text for generate.html.
3. Open https://eviltester.github.io/grid-table-editor/site/docs/test-data/generate-to-file.
4. Search the page text/metadata for generate.html.
5. Open https://eviltester.github.io/grid-table-editor/site/docs/test-data/Schema-Definition.
6. Search the page text for generate.html.
7. Compare route availability:
   • https://eviltester.github.io/grid-table-editor/generate.html
   • https://eviltester.github.io/grid-table-editor/generator.html
   • https://eviltester.github.io/grid-table-editor/site/generate.html
   • https://eviltester.github.io/grid-table-editor/site/generator.html

Expected Result

Published docs should consistently refer to the currently deployed generator route, generator.html, or avoid page-file names if the route is no longer meant to be user-facing.

Actual Result

• test-data/test-data-generation contains visible text such as Generate to File (generate.html).
• test-data/generate-to-file contains metadata/text such as Use generate.html.
• test-data/Schema-Definition says the schema editor is in app.html and generate.html.
• https://eviltester.github.io/grid-table-editor/generate.html returns 404.
• https://eviltester.github.io/grid-table-editor/site/generate.html returns 404.
• https://eviltester.github.io/grid-table-editor/generator.html returns 200.
• https://eviltester.github.io/grid-table-editor/site/generator.html returns 200.

Severity

Medium.

This is a docs/content consistency regression that can send users to a dead page or teach the wrong route name for the changed generator surface.

Notes

The app and generator shell links sampled in this pass point to generator.html; the stale generate.html references appear concentrated in the published docs content.

[eviltester]

Defect file: faker-docs-helpers-mustache-example-rejected.md

Full text from docs/testing/20260625/issue-228-001/defects/faker-docs-helpers-mustache-example-rejected.md:

Published helpers.mustache Faker Example Is Rejected By Runtime

Summary

The published faker docs include a helpers.mustache(...) example with an object-literal callback argument, but the deployed generator rejects that exact example as unsafe/too complex.

Environment

• URL: https://eviltester.github.io/grid-table-editor/generator.html
• Docs page: https://eviltester.github.io/grid-table-editor/site/docs/test-data/faker-test-data
• Branch: codex/228-improve-command-definition
• Commit: a3b39ddcfe0f
• Build: 2026-06-24T23:03:43.621Z

Steps To Reproduce

1. Open https://eviltester.github.io/grid-table-editor/site/docs/test-data/faker-test-data.

2. Find the published example:

   helpers.mustache("I found {{count}} instances.", { count: () => `${this.number.int()}` })

3. Open https://eviltester.github.io/grid-table-editor/generator.html.

4. Click Edit as Text.

5. Enter this schema:

   sentence
   helpers.mustache("I found {{count}} instances.", { count: () => `${this.number.int()}` })

6. Click Preview.

Expected Result

The docs example should generate preview values, or the docs should avoid presenting it as a supported schema example in the browser generator.

Actual Result

The preview output remains empty. The visible runtime error says:

Invalid Faker API Call Unsafe faker rule syntax detected: requires complex argument parsing

Control Checks

• helpers.fake("Hi, my name is {{person.firstName}} {{person.lastName}}!") generated names successfully.
• faker.helpers.fake("Hi, my name is {{person.firstName}} {{person.lastName}}!") generated names successfully.
• domain.helpers.fake("Hi") was rejected with visible guidance that helpers.* is faker-only, which matches the domain docs.

Severity

Medium.

The docs advertise an example that users can copy directly, but the current deployed generator rejects it. This is especially risky because issue #228 / PR #243 changed command definitions/help and users may rely on docs examples as the oracle for supported helper syntax.

Notes

If complex callback arguments are intentionally unsupported in browser schema text, the docs should use a safe helpers.mustache example or explicitly label this as a Faker API illustration rather than a supported generator schema rule.

[eviltester]

Defect file: issue-228-app-icon-controls-missing-accessible-names.md

Full text from docs/testing/20260625/issue-228-001/defects/issue-228-app-icon-controls-missing-accessible-names.md:

App embedded icon-only controls lack accessible names

Severity

Medium

Area

app.html embedded instructions, test-data schema, stored-schema, and import/export controls.

Environment

Deployed target: https://eviltester.github.io/grid-table-editor/app.html

Date observed: 2026-06-25

Summary

Several enabled icon-only controls on app.html have no visible text, aria-label, or title. They appear as compact icon buttons visually, but their accessible name is empty. This makes the controls difficult or impossible to identify for screen reader users and increases keyboard-discovery friction.

Reproduction

1. Open https://eviltester.github.io/grid-table-editor/app.html.
2. Inspect the compact icon buttons in the instructions/test-data/import-export areas.
3. Expand Test Data.
4. Generate rows from a schema to enable stored-schema actions.
5. Inspect enabled button[data-role] controls for visible text, aria-label, and title.

Expected

Every icon-only actionable button has a programmatic accessible name, for example via aria-label or title, matching the user action.

Actual

The following visible enabled buttons were observed with empty visible text, no aria-label, and no title:

[
  { "role": "instructions-action-button", "disabled": false },
  { "role": "stored-schemas-save-as", "disabled": false },
  { "role": "stored-schemas-recover-draft", "disabled": false },
  { "role": "stored-schemas-load-last-used", "disabled": false },
  { "role": "stored-schemas-clear-last-used", "disabled": false },
  { "role": "download-button", "disabled": false }
]

Additional compact buttons such as embedded schema load/save file buttons were also observed as icon-only without names during the initial app-page control scout.

Functional Control Check

The embedded test-data workflow itself worked after expanding Test Data:

1. Filled schema Status, enum, Open,Closed.
2. Generated three rows.
3. Confirmed Total rows: 3 and grid header Status.
4. Used grid-to-text and text-to-grid roundtrip successfully.

This defect is therefore about accessible naming and discoverability rather than broken generation.

Evidence

• ../screenshots/app-initial.png
• ../screenshots/app-generate-new-table.png
• ../screenshots/app-grid-text-roundtrip.png

Impact

Recent accessibility fixes may not cover the compact app-embedded controls. Screen reader users can encounter unnamed buttons, and sighted keyboard users get little contextual feedback beyond icons.

[eviltester]

Defect file: issue-228-bad-enum-quote-generates-corrupted-values.md

Full text from docs/testing/20260625/issue-228-001/defects/issue-228-bad-enum-quote-generates-corrupted-values.md:

Bad Enum Quote Generates Corrupted Values Instead Of Failing

Summary

Malformed enum quote syntax is accepted in both generator Preview and app Generate. Instead of failing validation, the deployed app generates corrupted values such as \\\"active and may report generation success.

Environment

• URL: https://eviltester.github.io/grid-table-editor/
• Deployment branch: codex/228-improve-command-definition
• Deployment commit: a3b39ddcfe0f
• Deployment build: 2026-06-24T23:03:43.621Z

Steps To Reproduce

Generator:

1. Open https://eviltester.github.io/grid-table-editor/generator.html.

2. Click Edit as Text.

3. Enter:

   status
   datatype.enum(values="active,pending)
   

4. Click Preview.

App:

1. Open https://eviltester.github.io/grid-table-editor/app.html.
2. Expand Test Data.
3. Use the text schema editor with the same schema.
4. Generate data.

Expected Result

The malformed quote should be rejected before generation with a visible row-level error that identifies the unclosed quote or malformed values argument.

Actual Result

• Generator Preview generated rows including corrupted value \\\"active.
• App Generate reported Generate complete. Grid updated. and populated values including \\\"active.

Evidence

Supporting raw evidence is in:

• ../negative-validation-matrix-results.json
• ../negative-validation-recheck-results.json
• ../negative-validation-app-sample-results.json
• negative-validation-defects.md

Repeatability

Repeated by the negative-validation subagent from a clean generator tab and in the app flow.

[eviltester]

Defect file: issue-228-boolean-probability-out-of-range-is-accepted.md

Full text from docs/testing/20260625/issue-228-001/defects/issue-228-boolean-probability-out-of-range-is-accepted.md:

Boolean Probability Out Of Range Is Accepted

Summary

datatype.boolean(probability=2) and datatype.boolean(probability=-0.1) generate data despite the documented probability range of 0 to 1.

Environment

• URL: https://eviltester.github.io/grid-table-editor/
• Deployment branch: codex/228-improve-command-definition
• Deployment commit: a3b39ddcfe0f
• Deployment build: 2026-06-24T23:03:43.621Z

Steps To Reproduce

1. Open generator.html.

2. Click Edit as Text.

3. Enter either schema:

   flag
   datatype.boolean(probability=2)
   

   flag
   datatype.boolean(probability=-0.1)
   

4. Click Preview.

5. Repeat probability=2 in app.html Test Data Generate.

Expected Result

Values outside the documented 0 to 1 probability range should be rejected before generation with a visible validation message.

Actual Result

• probability=2 generated all true.
• probability=-0.1 generated all false.
• App Generate reported success for probability=2.

Evidence

Supporting raw evidence is in:

• ../negative-validation-matrix-results.json
• ../negative-validation-recheck-results.json
• ../negative-validation-app-sample-results.json
• negative-validation-defects.md

Repeatability

Repeated by the negative-validation subagent in generator Preview and sampled in the app flow.

[eviltester]

Defect file: issue-228-controls-missing-accessible-names.md

Full text from docs/testing/20260625/issue-228-001/defects/issue-228-controls-missing-accessible-names.md:

Generator and app controls expose empty accessible names

Summary

Chrome's accessibility tree exposes empty names for several important deployed controls in the generator and app pages. The confirmed empty-name controls include the generator schema field type combobox, generator table preview searchbox, and app grid searchbox.

Environment

• URLs:
  • https://eviltester.github.io/grid-table-editor/generator.html
  • https://eviltester.github.io/grid-table-editor/app.html
• Date/time: 2026-06-25 00:13 Europe/London
• Viewport: mobile portrait, 360 x 740, device scale factor 2
• Browser: Chrome via DevTools Protocol with a temporary profile
• Related scope: issue improve command definition #228 / PR [codex] Refactor enum handling through domain commands #243 responsive and accessibility retest

Steps To Reproduce

1. Open https://eviltester.github.io/grid-table-editor/generator.html.
2. Inspect the Chrome accessibility tree for focusable controls.
3. Repeat on https://eviltester.github.io/grid-table-editor/app.html.
4. Compare control roles and accessible names.

Expected Result

Focusable controls should expose meaningful accessible names that describe their purpose. Examples:

• The generator schema type combobox should communicate that it selects the field type or method.
• The generator preview grid searchbox should communicate that it filters/searches the preview table.
• The app grid searchbox should communicate that it filters/searches the table column/grid.

Actual Result

Chrome accessibility tree returned these empty-name focusable controls:

generator.html
- role=combobox, empty name, focusable=true, hasPopup=menu
- role=searchbox, empty name, focusable=true, editable=plaintext

app.html
- role=searchbox, empty name, focusable=true, editable=plaintext

The route sweep also found adjacent unlabeled DOM controls in the same areas, including schema row inputs that rely on placeholders and table/search controls with no programmatic name.

Evidence

• Structured run data: ../responsive-accessibility-cdp-results.json
• Generator mobile screenshot: ../screenshots/responsive-a11y-grid-table-editor-generator-html-mobile-portrait-360x740.png
• App mobile screenshot: ../screenshots/responsive-a11y-grid-table-editor-app-html-mobile-portrait-360x740.png

Severity

Medium. These are focusable controls in core app/generator workflows, and empty accessible names make them difficult or impossible to understand with assistive technology.

Notes

This finding is based on Chrome's accessibility tree, not only DOM heuristics.

[eviltester]

Defect file: issue-228-empty-or-missing-enum-values-have-weak-feedback.md

Full text from docs/testing/20260625/issue-228-001/defects/issue-228-empty-or-missing-enum-values-have-weak-feedback.md:

Empty Or Missing Enum Values Have Weak Feedback

Summary

Empty or missing enum values produce inconsistent and weak feedback across generator and app flows.

Environment

• URL: https://eviltester.github.io/grid-table-editor/
• Deployment branch: codex/228-improve-command-definition
• Deployment commit: a3b39ddcfe0f
• Deployment build: 2026-06-24T23:03:43.621Z

Steps To Reproduce

Generator:

1. Open generator.html.

2. Click Edit as Text.

3. Enter either:

   status
   datatype.enum(values="")
   

   status
   datatype.enum()
   

4. Click Preview.

App:

1. Open app.html.
2. Expand Test Data.
3. Generate with datatype.enum(values="").

Expected Result

Both generator and app should show a visible, actionable validation message, such as Row 1: datatype.enum requires at least one non-empty value.

Actual Result

• Generator Preview produced no output and no visible validation message.
• App Generate reported only Generate failed. Check console for details. and retained previous grid data.

Evidence

Supporting raw evidence is in:

• ../negative-validation-matrix-results.json
• ../negative-validation-recheck-results.json
• ../negative-validation-app-sample-results.json
• negative-validation-defects.md

Repeatability

Repeated by the negative-validation subagent in generator Preview and sampled in the app flow.

[eviltester]

Defect file: issue-228-generator-schema-row-tab-order-trap.md

Full text from docs/testing/20260625/issue-228-001/defects/issue-228-generator-schema-row-tab-order-trap.md:

Generator schema row tab order traps focus before method/value controls

Summary

On the deployed PR #243 build, keyboard users cannot reliably tab through the generator schema row. From the Column Name input, Tab moves focus to body, then back to the row action buttons and the same Column Name input, repeatedly. Focus does not advance to the field type picker, the value/regex input, schema constraints, or generation controls.

Environment

• URL: https://eviltester.github.io/grid-table-editor/generator.html
• Date/time: 2026-06-25 00:13 Europe/London
• Viewport: mobile portrait, 360 x 740, device scale factor 2
• Browser: Chrome via DevTools Protocol with a temporary profile
• Related scope: issue improve command definition #228 / PR [codex] Refactor enum handling through domain commands #243 responsive and accessibility retest

Steps To Reproduce

1. Open https://eviltester.github.io/grid-table-editor/generator.html.
2. Use a 360 x 740 mobile viewport.
3. Focus the schema row Column Name text input.
4. Press Tab repeatedly.

Expected Result

Focus should move forward through the schema row controls in page order, including the field type picker, the value/regex input, schema constraints, Add Field, stored schema controls, and then the generation controls.

Actual Result

Focus cycles back through the row action buttons and the same column-name field. The confirmed trace from a clean page was:

start: input text "Column Name"
Tab 1: body
Tab 2: button "Drag field to reorder"
Tab 3: button "Insert field after this row"
Tab 4: button "Remove field"
Tab 5: input text "Column Name"
Tab 6: body
Tab 7: button "Drag field to reorder"
Tab 8: button "Insert field after this row"

Evidence

• Structured run data: ../responsive-accessibility-cdp-results.json
• Screenshot after the targeted tab-order recheck: ../screenshots/responsive-a11y-generator-tab-after-column-name.png
• Baseline mobile generator screenshot: ../screenshots/responsive-a11y-grid-table-editor-generator-html-mobile-portrait-360x740.png

Severity

Medium. This blocks keyboard-only access to important generator schema controls and is directly tied to the PR's accessibility and picker-related risk areas.

Notes

The same repeating pattern appeared in the broader desktop and mobile tab traces captured during the route sweep.

[eviltester]

Defect file: issue-228-invalid-number-and-date-constraints-generate-error-rows.md

Full text from docs/testing/20260625/issue-228-001/defects/issue-228-invalid-number-and-date-constraints-generate-error-rows.md:

Invalid Number And Date Constraints Generate Error Rows

Summary

Invalid numeric/date constraints generate literal **ERROR** rows instead of failing validation before generation.

Environment

• URL: https://eviltester.github.io/grid-table-editor/
• Deployment branch: codex/228-improve-command-definition
• Deployment commit: a3b39ddcfe0f
• Deployment build: 2026-06-24T23:03:43.621Z

Steps To Reproduce

Generator:

1. Open generator.html.

2. Click Edit as Text.

3. Enter:

   n
   number.int(min=1,max=10,multipleOf=0)
   

4. Click Preview.

5. Repeat with:

   d
   date.recent(days=-7)
   

App:

1. Open app.html.
2. Expand Test Data.
3. Generate with number.int(min=1,max=10,multipleOf=0).

Expected Result

Invalid constraints should fail validation before generation. The app should not report success when output contains internal **ERROR** placeholders.

Actual Result

• Generator Preview produced **ERROR** rows for both invalid rules.
• App Generate reported Generate complete. Grid updated. for multipleOf=0 and inserted **ERROR** rows.

Evidence

Supporting raw evidence is in:

• ../negative-validation-matrix-results.json
• ../negative-validation-recheck-results.json
• ../negative-validation-app-sample-results.json
• negative-validation-defects.md

Repeatability

Repeated by the negative-validation subagent in generator Preview and sampled in the app flow.

[eviltester]

Defect file: issue-228-modal-focus-not-restored.md

Full text from docs/testing/20260625/issue-228-001/defects/issue-228-modal-focus-not-restored.md:

Modal focus is not restored to trigger after Escape close

Severity

Medium

Area

generator.html method picker and params editor modal keyboard/focus paths.

Environment

Deployed target: https://eviltester.github.io/grid-table-editor/generator.html

Date observed: 2026-06-25

Summary

Closing the method picker or params editor with Escape closes the modal but leaves focus on <body> instead of returning focus to the control that opened the modal. Keyboard and assistive-technology users lose their place in the schema row after dismissing either modal.

Reproduction - Method Picker

1. Open https://eviltester.github.io/grid-table-editor/generator.html.
2. Change the first schema row type to faker.
3. Focus Select faker command.
4. Press Enter to open the method picker.
5. Observe focus moves to the picker search input.
6. Press Escape.

Expected

The picker closes and focus returns to the Select faker command button that opened it.

Actual

The picker closes and focus lands on <body>.

Observed focus state after Escape:

{
  "modalVisible": false,
  "active": {
    "tag": "BODY",
    "cls": "theme-light"
  }
}

Reproduction - Params Editor

1. Open https://eviltester.github.io/grid-table-editor/generator.html.
2. Change the first schema row type to faker.
3. Open the method picker.
4. Switch to All, search number.int, select it, and Apply.
5. Focus the params button.
6. Press Enter to open the params editor.
7. Observe focus moves to min value.
8. Press Escape.

Expected

The params editor closes and focus returns to the params button that opened it.

Actual

The params editor closes and focus lands on <body>.

Observed focus state after Escape:

{
  "modalVisible": false,
  "active": {
    "tag": "BODY",
    "cls": "theme-light"
  }
}

Evidence

• ../screenshots/method-picker-keyboard-after-esc.png
• ../screenshots/params-editor-keyboard-after-esc.png

Impact

The modal workflows are keyboard-operable enough to open and close, but users must manually rediscover their location in the form after closing. This is especially frustrating in multi-row schemas and creates an accessibility regression risk.

[eviltester]

Defect file: issue-228-unknown-enum-named-argument-is-accepted.md

Full text from docs/testing/20260625/issue-228-001/defects/issue-228-unknown-enum-named-argument-is-accepted.md:

Unknown Enum Named Argument Is Accepted

Summary

datatype.enum accepts an unknown named argument valuez instead of rejecting it. Generation proceeds without a visible validation error.

Environment

• URL: https://eviltester.github.io/grid-table-editor/generator.html
• Deployment branch: codex/228-improve-command-definition
• Deployment commit: a3b39ddcfe0f
• Deployment build: 2026-06-24T23:03:43.621Z

Steps To Reproduce

1. Open generator.html.

2. Click Edit as Text.

3. Enter:

   status
   datatype.enum(valuez="active,pending")
   

4. Click Preview.

Expected Result

The command should reject valuez as an unknown argument and show an actionable message such as Unknown argument "valuez"; expected "values".

Actual Result

Generation proceeds with no visible validation error. The subagent observed output in both the initial matrix and clean recheck.

Evidence

Supporting raw evidence is in:

• ../negative-validation-matrix-results.json
• ../negative-validation-recheck-results.json
• negative-validation-defects.md

Repeatability

Repeated by the negative-validation subagent in generator Preview.

[eviltester]

Defect file: negative-validation-defects.md

Full text from docs/testing/20260625/issue-228-001/defects/negative-validation-defects.md:

Negative Validation Defects

Summary

Several malformed or invalid schema rules are accepted, silently fail, or generate **ERROR** data instead of producing useful validation messages. The affected behavior was observed on the deployed PR #243 test environment only.

• Environment: https://eviltester.github.io/grid-table-editor/
• Branch: codex/228-improve-command-definition
• Commit: a3b39ddcfe0f
• Build: 2026-06-24T23:03:43.621Z
• Evidence files:
  • ../negative-validation-matrix-results.json
  • ../negative-validation-recheck-results.json
  • ../negative-validation-app-sample-results.json
  • ../screenshots/negative-validation-app-multipleof-zero-error-success.png

Confirmed Behaviors

1. Bad enum quote generates corrupted values instead of failing

Schema:

status
datatype.enum(values="active,pending)

Generator Preview:

• Generated rows such as \\\"active and pending.
• No visible validation error appeared.

Main app Generate:

• Reported Generate complete. Grid updated.
• Updated the grid with values including \\\"active.

Expected:

• The malformed quote should be rejected before generation with a visible row-level error that identifies the unclosed quote or malformed values argument.

2. Unknown enum named argument is accepted

Schema:

status
datatype.enum(valuez="active,pending")

Generator Preview:

• Generated data with no visible validation error.
• Initial matrix produced values including valuez=active and pending; clean recheck produced pending values.

Expected:

• Unknown named argument valuez should be rejected for datatype.enum, with a message such as Unknown argument "valuez"; expected "values".

3. Boolean probability accepts values outside documented range

Schemas:

flag
datatype.boolean(probability=2)

flag
datatype.boolean(probability=-0.1)

Generator Preview:

• probability=2 generated all true.
• probability=-0.1 generated all false.
• No visible validation error appeared.

Main app Generate:

• probability=2 reported Generate complete. Grid updated. and generated all true.

Expected:

• Values outside the documented 0 to 1 probability range should be rejected before generation.

4. Invalid numeric/date constraints generate **ERROR** rows

Schemas:

n
number.int(min=1,max=10,multipleOf=0)

d
date.recent(days=-7)

Generator Preview:

• Both rules generated **ERROR** rows with no visible validation message.

Main app Generate:

• number.int(min=1,max=10,multipleOf=0) reported Generate complete. Grid updated. and inserted **ERROR** rows into the grid.

Expected:

• Invalid constraints should fail validation before generation.
• The app should not report success when generated rows contain internal **ERROR** placeholders.

5. Empty or missing enum values have inconsistent/weak feedback

Schemas:

status
datatype.enum(values="")

status
datatype.enum()

Generator Preview:

• Produced no output.
• No visible validation error appeared.

Main app Generate for values="":

• Reported Generate failed. Check console for details.
• Left the previous grid data visible.

Expected:

• Both generator and app should show a visible, actionable validation message, e.g. Row 1: datatype.enum requires at least one non-empty value.

Severity

Medium.

Rationale: core generation flows remain available, but malformed schemas can produce corrupted data, successful-looking **ERROR** output, or non-actionable failures across the generator/app flows touched by PR #243 validation work.

Notes

Some invalid inputs did produce useful validation messages and are not filed as defects here:

• number.int(min=10,max=1) correctly reported that min must be less than or equal to max.
• helpers.arrayElement(values="active,pending") correctly failed as unsafe/complex faker syntax.
• Stray enum commas failed visibly, though the wording could be improved.