Commands should accept legacy ID format (`minecraft:zombie` instead of `entity:minecraft/zombie`)

[CodeBot101]

Describe the Bug

Scanning an entry via Spyglass or Exposure Camera doesn't actually run the commands I've set up anymore (it was working on previous versions—but I haven't checked in probably a ~month worth of updates, since I just assumed it'd continue working)

This is my server.json; let me know if anything is written incorrectly:

{
  "disableScanning": false,
  "disableLootDisplay": false,
  "disableBiomeDisplay": false,
  "disableEditingDescriptions": false,
  "disableEditingNames": false,
  "disableVariants": false,
  "keepSilhouetteWhenUnlocked": false,
  "unlockAllVariants": false,
  "enableFieldGuideItem": false,
  "requireItemToOpen": false,
  "enableCopyingPages": true,
  "hideTabsUntilUnlocked": false,
  "enableSpyglassScanning": true,
  "spyglassScanDistance": 64.0,
  "enableNakedEyeScanning": false,
  "nakedEyeScanDistance": 10.0,
  "showUndiscoveredNames": false,
  "hideUndiscoveredFromSearch": false,
  "scanSpeed": 1.0,
  "grantXpOnScan": true,
  "xpAmountOnScan": 5,
  "enableReliableRemover": true,
  "exposureUnlockViaPhotograph": true,
  "globalScanCommands": [],
  "categoryScanCommands": {},
  "entryScanCommands": {
    "itfollowsmod:follower": [
      "/ftbquests change_progress @p complete 33825AD55BAD554B"
    ],
    "revervox_mod:revervox": [
      "/ftbquests change_progress @p complete 413B01EF895371F6"
    ],
    "minecraft:zombie": [
      "/ftbquests change_progress @p complete 1F2FA9658CB8727D"
    ],
    "goat_man:goat_man": [
      "/ftbquests change_progress @p complete 472AD59807E5D163"
    ],
    "minecraft:sheep": [
      "/ftbquests change_progress @p complete 13C89CBDEBD1F82E"
    ]
  }
}

I've tried resetting the game, making new worlds, running /field_guide reload to clear cache, and refreshing the config files to re-enter the info. I suppose I could try reinstalling the entire mod?

Maybe this mod doesn't play nice with modded entities or FTBQuests commands anymore?

Reproduction Steps

1. Get Field Guide + Immersive Overlays, Item Descriptions, and even the Mod Descriptions resource pack, in case that's somehow what's breaking things.
2. Get Exposure (latest beta version; 1.9.20)
3. Get FTB Quests

• All the dependencies, too, of course

4. Create a Quest in-game with a "Custom" task. Right-click the task, then click "Copy ID" at the bottom
5. Get an Exposure Camera (with Film inside; Black and White film, if it matters)
6. Set up the following command (you can use any mob, I'm fairly sure; they all don't work) in the Field Guide commands section:

[...]
  "entryScanCommands": {    
      "minecraft:zombie": [
      "/ftbquests change_progress @p complete [Enter the actual ID of the Quest here]"
      ]
  }
}

7. Reload fieldguide, or reload/restart the whole game if you want
8. Take a picture of the mob (or use the Spyglass; neither will work)
9. Nothin'

Expected Result

Field Guide would complete the Quest upon taking a picture of the mob.

Screenshots and Videos

No response

Operating System

Windows 11

Mod Version

1.7.3

Minecraft Version

1.20.1

Mod Loader

Forge

Other Mods / Modpack

I was using a fresh install for this final test, but SCE Protocol is the modpack I came from originally

Additional Context

No response

[evanbones]

Instead of minecraft:zombie for example, try entity:minecraft/zombie. After adding items, the ID format had to be changed to account for edge cases like salmon items vs entities. I should definitely have the original IDs as a fallback though

[CodeBot101]

Ah, okay, I'll try that; thanks

Update: Interesting, that did actually work after a full restart. Nice!

I think a clearer "Configured" description might help a lot too, because right now it still just says the syntax is something like "entity_id=/command1;command2," which (at least to me) doesn't really imply the syntax is "entity:minecraft/zombie"; I'd just assume it wants the usual "/summon" ID

Anywho, I'll test once more on my actual mod pack with the new "entity" prefix and see if it's still working there. If it is, I'll close this (or you can close it now tbh; either way), but I sadly can't test right now because I gotta leave lul.

Thanx for the quick response though

[evanbones]

Good call, yeah, the wiki has a note about the IDs but it should be more clear in-game as well. I'm gonna leave this open for now so I don't forget to have the mod accept the old ID format as a fallback

[CodeBot101]

Nvm, I had some time to test it; it works

Thanks!

[CodeBot101]

Oops- uh.. I posted my comment but yours hadn't rendered yet, lol. My bad .-.