Skip to content

Commit cab974f

Browse files
etrclaude
andcommitted
TASK-064: document live-MHD and deprecated negative-compile coverage gaps
test-quality-reviewer-iter3-4: Add comment to second_call_does_not_reallocate explaining that the cookies_parsed_cache_ guard via the create_test_request() builder path is tested, but the live MHD_get_connection_values path is only covered by integration tests. test-quality-reviewer-iter3-5: Expand comment in cookie_deprecation_sentinel_test recording that the CMake try_compile() negative-compile sentinel (confirming [[deprecated]] is emitted with -Werror) is a pending follow-up. Points to the cookie_header_sentinel_test.cpp pattern as the available infrastructure. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 15d5d70 commit cab974f

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

test/unit/cookie_deprecation_sentinel_test.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,13 @@
3030
// in this comment and rely on the existing CI warning-summary step plus
3131
// the spot-checked grep in scripts/check-doxygen.sh.
3232
//
33+
// test-quality-reviewer-iter3-5: mechanical verification of the negative
34+
// compile (i.e. a CMake try_compile() sentinel that confirms
35+
// with_cookie(string,string) emits -Wdeprecated-declarations with -Werror)
36+
// is recorded as a follow-up task. The cookie_header_sentinel_test.cpp
37+
// pattern shows the project has infrastructure for compile-only tests;
38+
// the CMake-side negative-compile harness is the missing piece.
39+
//
3340
// Pure compile test -- empty LDADD.
3441

3542
#include <string>

test/unit/http_request_cookies_parsed_test.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,13 @@ LT_END_AUTO_TEST(reference_stable_across_calls)
9595

9696
LT_BEGIN_AUTO_TEST(http_request_cookies_parsed_suite,
9797
second_call_does_not_reallocate)
98+
// This test exercises the cookies_parsed_cache_ guard via the
99+
// create_test_request() builder path (cookies_parsed_cache_built_
100+
// is set during build). The live MHD path — where
101+
// cookies_parsed_cache_built_ is set on the first MHD_get_connection_values
102+
// call — is only exercised by integration tests (test/integ/).
103+
// See test-quality-reviewer-iter3-4: the live-MHD branch is accepted
104+
// as integration-test-only coverage.
98105
http_request req = create_test_request()
99106
.path("/").method("GET")
100107
.cookie("sid", "abc")

0 commit comments

Comments
 (0)