Update to clang 3.7

[AlessandroSangiuliano]

Updating to clang 3.7, while compiling étoilé, the following file has this output:

Languages/LanguageKit/CodeGen/LLVMCompat.h:30:10: fatal error:
'llvm/DebugInfo.h' file not found

include <llvm/DebugInfo.h>

This is because DebugInfo.h is now located in:

/usr/local/include/llvm/IR/DebugInfo.h (on ubuntu)

so the path in llvm changed to llvm/IR/DebugInfo.h.

This fix is needed to complete the LanguageKit build.

It oculd be just a problem in ubuntu or a problem in my Ubuntu. I'll check and will close or confirm the problem as soon as I can.

Update: problem confirmed, fix needed. I just checked the file, it includes llvm/DebugInfo.h

[AlessandroSangiuliano]

In the file Compat.h, I tried a simple fix adding just a preprocess check.
At line 30 I just done:

#if (LLVM_MINOR < 7)
#include <llvm/DebugInfo.h>
#else
#include <llvm/IR/DebugInfo.h>

This works, but not committed because I should check if there's a better way to fix it. However I done this fix to see the actual build with clang 3.7. After this fix the build stops again this time here:

In file included from AMD64/../ABIInfo.h:82:
/home/alex/Etoile/Languages/LanguageKit/CodeGen/LLVMCompat.h:8:2: error:
unterminated conditional directive
#ifndef LANGUAGEKIT_LLVM_HACKS
^
In file included from AMD64/AMD64ABIInfo.mm:41:
AMD64/../CodeGenModule.h:112:47: error: call to implicitly-deleted copy
constructor of 'llvm::DICompileUnit'
DICompileUnit getModuleDescriptor() { return ModuleScopeDescriptor; }
^~~~~~~~~~~~~~~~~~~~~
/usr/local/include/llvm/IR/DebugInfoMetadata.h:968:23: note: copy constructor of
'DICompileUnit' is implicitly deleted because base class 'llvm::DIScope'
has a deleted copy constructor
class DICompileUnit : public DIScope {
^
/usr/local/include/llvm/IR/DebugInfoMetadata.h:404:17: note: copy constructor of
'DIScope' is implicitly deleted because base class 'llvm::DINode' has a
deleted copy constructor
class DIScope : public DINode {
^
/usr/local/include/llvm/IR/DebugInfoMetadata.h:144:16: note: copy constructor of
'DINode' is implicitly deleted because base class 'llvm::MDNode' has a
deleted copy constructor
class DINode : public MDNode {
^
/usr/local/include/llvm/IR/Metadata.h:744:3: note: 'MDNode' has been explicitly
marked deleted here
MDNode(const MDNode &) = delete;
^
In file included from AMD64/AMD64ABIInfo.mm:41:
AMD64/../CodeGenModule.h:113:44: error: call to implicitly-deleted copy
constructor of 'llvm::DIFile'
DIFile getSourceFileDescriptor() { return ModuleSourceFile; }
^~~~~~~~~~~~~~~~
/usr/local/include/llvm/IR/DebugInfoMetadata.h:457:16: note: copy constructor of
'DIFile' is implicitly deleted because base class 'llvm::DIScope' has a
deleted copy constructor
class DIFile : public DIScope {
^
/usr/local/include/llvm/IR/DebugInfoMetadata.h:404:17: note: copy constructor of
'DIScope' is implicitly deleted because base class 'llvm::DINode' has a
deleted copy constructor
class DIScope : public DINode {
^
/usr/local/include/llvm/IR/DebugInfoMetadata.h:144:16: note: copy constructor of
'DINode' is implicitly deleted because base class 'llvm::MDNode' has a
deleted copy constructor
class DINode : public MDNode {
^
/usr/local/include/llvm/IR/Metadata.h:744:3: note: 'MDNode' has been explicitly
marked deleted here
MDNode(const MDNode &) = delete;
^
1 warning and 5 errors generated.

[davidchisnall]

Yes, there are lots of changes to the LLVM APIs each revision. Updating LanguageKit will require some quite significant changes. I'm not really happy with the current design of LanguageKit, so I'm not particularly motivated to do this at the moment, but patches are welcome if someone else wants to.