Merge pull request #58 from ethereumfollowprotocol/notif-start-ts

notifications start timestamp param

Author: 0xthrpw

src/router/api/v1/users/notifications/index.ts

@@ -11,10 +11,11 @@ export function notifications(users: Hono<{ Bindings: Environment }>, services:
   users.get('/:addressOrENS/notifications', includeValidator, async context => {
     const { addressOrENS } = context.req.param()
     const { cache } = context.req.query()
-    let { offset, limit, opcode, interval, tag } = context.req.valid('query')
+    let { offset, limit, opcode, start, interval, tag } = context.req.valid('query')
     if (!limit) limit = '10'
     if (!offset) offset = '0'
     if (!(opcode && [1, 2, 3, 4].includes(Number(opcode)))) opcode = '0'
+    if (!start || start === '') start = Math.floor(Date.now() / 1000).toString()
     if (!tag || tag === '') tag = 'p_tag_empty'
     if (interval === 'hour') interval = '1:00:00'
     else if (interval === 'day') interval = '24:00:00'
@@ -24,7 +25,7 @@ export function notifications(users: Hono<{ Bindings: Environment }>, services:
     else interval = '168:00:00'
 
     const cacheService = services.cache(env(context))
-    const cacheTarget = `users/${addressOrENS}/notifications?opcode=${opcode}&interval=${interval}&tag=${tag}&limit=${limit}&offset=${offset}`
+    const cacheTarget = `users/${addressOrENS}/notifications?opcode=${opcode}&start=${start}&interval=${interval}&tag=${tag}&limit=${limit}&offset=${offset}`
 
     if (cache !== 'fresh') {
       const cacheHit = await cacheService.get(cacheTarget)
@@ -41,7 +42,15 @@ export function notifications(users: Hono<{ Bindings: Environment }>, services:
 
     const notifications: NotificationRow[] = await services
       .efp(env(context))
-      .getNotificationsByAddress(address, opcode as string, interval, tag as string, limit as string, offset as string)
+      .getNotificationsByAddress(
+        address,
+        opcode as string,
+        BigInt(start as string),
+        interval,
+        tag as string,
+        limit as string,
+        offset as string
+      )
 
     const response = notifications.map(notification => {
       return {

src/service/efp-indexer/mock/service.ts

@@ -133,6 +133,7 @@ export class MockEFPIndexerService implements IEFPIndexerService {
   getNotificationsByAddress(
     _address: Address,
     _opcode: string,
+    _start: bigint,
     _interval: string,
     _tag: string,
     _limit: string,

src/service/efp-indexer/service.ts

@@ -246,6 +246,7 @@ export interface IEFPIndexerService {
   getNotificationsByAddress(
     address: Address,
     opcode: string,
+    start_timestamp: bigint,
     interval: string,
     tag: string,
     limit: string,
@@ -457,12 +458,13 @@ export class EFPIndexerService implements IEFPIndexerService {
   async getNotificationsByAddress(
     address: Address,
     opcode: string,
+    start_timestamp: bigint,
     interval: string,
     tag: string,
     limit: string,
     offset: string
   ): Promise<NotificationRow[]> {
-    const query = sql<NotificationRow>`SELECT * FROM query.get_notifications_by_address_tags(${address}, ${opcode}, ${interval}, ${tag}, ${limit}, ${offset})`
+    const query = sql<NotificationRow>`SELECT * FROM query.get_notifications_by_address_tags(${address}, ${opcode}, ${start_timestamp}, ${interval}, ${tag}, ${limit}, ${offset})`
     const result = await query.execute(this.#db)
     if (!result || result.rows.length === 0) {
       return []