Skip to content

Bug in DSTContract.sol submitHKGProposal #10

Description

@kpii

In submitHKGProposal() the parameter requestValue is an amount in HKG. According to the whitepaper, it should be "possible to request up to 20% of the HKG funds every 2 weeks".

The corresponding check in the code should compare requestValue with the HKG balance of the contract (e.g. using getHKGOwned()).

However, on lines 392 and 397 requestValue is checked against preferedQtySold which is a value in DST tokens.

If preferedQtySold is higher than the HKG balance this allows to submit a proposal for a higher amount, up to the full HKG balance of the contract.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions