fix(web_fetch): reuse network proxy resolution#3614
Merged
Conversation
esengine
approved these changes
Jun 9, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
Clean refactor — collapsing the proxy URL into ProxySpec and reusing the resolver while keeping web_fetch's SSRF guard is exactly right. Verified the CONNECT-proxy and SSRF-block paths end-to-end locally. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates
web_fetchto reuse Reasonix's shared network proxy resolver instead of using a static proxy URL resolved during boot.Before this change:
web_fetchreceived a flattened proxy URL fromnetclient.ResolveProxyURL.no_proxy, env/auto/custom proxy behavior, and redirect boundaries could diverge fromnetclient.automode could not be reused byweb_fetch.After this change:
web_fetchcarries the fullnetclient.ProxySpec.env,auto,custom,no_proxy, andDirectHostsnow follow the same resolver path as other network clients.web_fetch: direct dials still vet resolved IPs, and proxied IP-literal targets are still blocked.Issues
Fixes #3610
Fixes #3510
Implementation notes
netclient.ProxyFuncas a thin wrapper around the existing resolver.web_fetch's staticproxyURLfield withnetclient.ProxySpec.web_fetch.ResolveProxyURLhelper.web_fetch.Tests
go test ./internal/tool/builtin -run 'TestWebFetchUsesEnvProxyAtRequestTime|TestWebFetchProxySpecHonorsNoProxy|TestWebFetchRechecksProxySpecAfterRedirect'go test ./internal/tool/builtin ./internal/netclient ./internal/boot ./internal/cligit ls-files '*.go' | xargs ../.tools/go/bin/gofmt -lgit diff --checkgo test ./...go vet ./...go build ./...go test -race ./...