From 960f8d04e0fc5afbbf0a0055816a6bbf46ed7c2e Mon Sep 17 00:00:00 2001 From: olaven Date: Tue, 29 Jan 2019 22:31:09 +0100 Subject: [PATCH 1/2] safe updating of state --- src/main/resources/app/containers/headless.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/resources/app/containers/headless.js b/src/main/resources/app/containers/headless.js index fdd2ccf..bff6339 100644 --- a/src/main/resources/app/containers/headless.js +++ b/src/main/resources/app/containers/headless.js @@ -33,8 +33,8 @@ class HeadlessPage extends React.PureComponent { this.props.history.push(URLS.headless); this.getItems() .then(result => { - this.setState({ - items : this.state.items.concat(result.data.guillotine.query) + this.setState(previousState => { + items: previousState.items.concat(result.data.guillotine.query); }); }) .catch(e => console.error('Headless site is not configured correctly', e)); From dabf70e72177544e850168068d20a1fb8b8d8582 Mon Sep 17 00:00:00 2001 From: olaven Date: Wed, 30 Jan 2019 16:06:16 +0100 Subject: [PATCH 2/2] the return has to be explicit --- src/main/resources/app/containers/headless.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/resources/app/containers/headless.js b/src/main/resources/app/containers/headless.js index bff6339..00db7df 100644 --- a/src/main/resources/app/containers/headless.js +++ b/src/main/resources/app/containers/headless.js @@ -34,7 +34,9 @@ class HeadlessPage extends React.PureComponent { this.getItems() .then(result => { this.setState(previousState => { - items: previousState.items.concat(result.data.guillotine.query); + return { + items: previousState.items.concat(result.data.guillotine.query) + } }); }) .catch(e => console.error('Headless site is not configured correctly', e));