Skip to content

Fix: Dapper: do not return any items when filtering on an empty array #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwdb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Dapper: do not return any items when filtering on an empty array #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...les/persistence/Elsa.Persistence.Dapper/Extensions/ParameterizedQueryBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,14 +184,21 @@ public static ParameterizedQuery WorkflowDefinitionSearchTerm(this Parameterized
/// <summary>
/// Appends an AND clause to the query if the value is not null.
/// </summary>
/// <remarks>If the values field is empty but not null, this adds an always false filter.</remarks>
/// <param name="query">The query.</param>
/// <param name="field">The field.</param>
/// <param name="values">The values.</param>
public static ParameterizedQuery In(this ParameterizedQuery query, string field, IEnumerable<object>? values)
{
var valueList = values?.ToList();

if (valueList == null || !valueList.Any()) return query;
if (valueList == null) return query;

if (valueList.Count == 0)
{
query.Sql.AppendLine("and 1=0");
return query;
}

var fieldParamNames = valueList
.Select((_, index) => $"@{field}{index}")
Expand Down