Skip to content

[ux-design-patrol] Inconsistent Azure IDF validation uses struct-field names instead of config-key style #50952

@github-actions

Description

@github-actions

Recent commits have introduced UI/UX patterns that diverge from established patterns elsewhere in the codebase. The following inconsistency reduces design consistency for users.

Design Drift Findings

1. Azure identity federation validation errors use PascalCase struct fields while existing config errors use config-key wording

Commit(s): aa1949f6399d1760972d3a143b3dbb0afb5480a0 (Consolidate IDF auth #50280)

New pattern (introduced by commit):

TenantID is required
ClientID is required
JWTFilePath is required

Existing pattern (established elsewhere):

tenant_id is required when using client_secret authentication
client_id is required when using client_secret authentication

and in identity federation validation:

audience is required
global role ARN is required
JWT file path is required

Location of new pattern:

  • x-pack/libbeat/common/identityfederation/azure.go:38-45

Location of existing pattern:

  • x-pack/filebeat/input/azureeventhub/config.go:299-303
  • x-pack/libbeat/common/identityfederation/gcp.go:58-65

User impact: Users hitting Azure IDF misconfiguration errors see internal Go field names (TenantID, JWTFilePath) instead of the config-oriented naming style used elsewhere. This makes troubleshooting less consistent across Beats auth/config errors and can slow correction of settings.

Suggested Actions

  • Update Azure IDF validation messages in x-pack/libbeat/common/identityfederation/azure.go to follow existing user-facing config/error wording conventions (config-key or natural-language names rather than struct field identifiers).
  • Keep Azure/GCP/AWS identity federation validation message styles aligned to a shared convention for required-parameter errors.

Note

🔒 Integrity filter blocked 82 items

The following items were blocked because they don't meet the GitHub integrity level.

  • #50911 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50900 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50897 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50875 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50859 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50858 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50853 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50840 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50834 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50808 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50802 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50792 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50786 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50772 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50702 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #50681 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • ... and 66 more items

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

What is this? | From workflow: UX Design Patrol

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

  • expires on Jun 3, 2026, 2:18 PM UTC

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs_teamIndicates that the issue/PR needs a Team:* label

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions