the method getResource should have issue on line 164

[hylinux]

Hi, I just tried use the library for my project.
but I found there is a issue in method getResource in class EhcacheShiroManager

the line 164. I found the code always strip the prefix. but when we put the path into. the code use a url for it.

then it always throws a MalformedURLException, and Caused by: java.net.MalformedURLException: no protocol:

I suppose this is a bug for this code.

thanks

Mike

[nenko-tabakov]

Hi,
have you tried adding a 'file:/' prefix to the path?

Kind regards,
Nenko

[hylinux]

yes. I did.

still got that issue....

[henri-tremblay]

This error can be easily reproduced with

  @Test
  public void testNoPrefix() {
    EhcacheShiroManager cacheManager = new EhcacheShiroManager();
    cacheManager.setCacheManagerConfigFile("file:config/ehcache.xml");
    Cache<Object, Object> someCache = cacheManager.getCache("someCache");
    assertNotNull(someCache);
  }
}

I think the correct code should mimic ResourceUtils.getInputStreamForPath.

[bmarwell]

I can see the fix in the code, where this was changed:

if (cacheManagerConfigFile.startsWith(ResourceUtils.CLASSPATH_PREFIX)) {
      return EhcacheShiroManager.class.getClass().getResource(stripPrefix(cacheManagerConfigFile));
    }

to this:

if (cacheManagerConfigFile.startsWith(ResourceUtils.CLASSPATH_PREFIX)) {
      return ClassUtils.getResource(configFileWithoutPrefix);
    }

@nenko-tabakov can you please release the fix?