take options by reference wherever possible

[nilslice]

In the updated adapter.start calls or wherever we're passing in options, we should take the value by reference vs. expecting to own it. particularly in Rust, currently each trace context must make its own new Options, or if cloneable, copy it from elsewhere.

e.g.

- let trace_ctx = adapter.start(_, _, options);
+ let trace_ctx = adapter.start(_, _, &options);

It could also be done in Go so the value isn't copied around, but that's more of a performance/resource optimization than a pesky DX as it is in Rust.

[nilslice]

cc/ @wikiwong, just tagging you on this so we can talk it through later!

[wikiwong]

thanks for capturing this @nilslice ! I went down this direction initially in Rust then ended up with some whacky looking lifetime declarations, could def use some help figuring out how to do this in the me most idiomatic way

As for Go, we are passing Options by reference into NewTraceCtx so we should be good there!