Some modifiers not removed by RemoveModifier if hero is invulnerable

[gelguy]

• Nero's modifier_gladiusanus_blauserum
• Saber's modifier_instinct_crit_hit
• Alter's modifier_darklight_crit_hit
• Avenger's modifier_murderous_instinct_crit_hit
• Lancer 4's modifier_rampant_warrior_crit_hit (the critical rate is 100% but he can get extra critical attacks after the duration of combo is over but the modifier is still in place)
• Extra Assassin's modifier_martial_arts_crit_hit
• Berserker 5's modifier_courage_attack_damage_buff

Most of these are critical hit modifiers which need the DOTA_UNIT_TARGET_FLAG_INVULNERABLE flag.

For Nero's Q: Beta 1.44d changelog indicates it has been fixed but it currently is not.

The invulnerability flag is present in

fateanother/game/dota_addons/fateanother/scripts/npc/npc_abilities_custom.txt

Line 19897 in b2918e2

"Flags" "DOTA_UNIT_TARGET_FLAG_INVULNERABLE"

but not in

fateanother/game/dota_addons/fateanother/scripts/npc/npc_abilities_custom.txt

Line 19976 in b2918e2

"Target" "CASTER"

.

[gelguy]

It appears setting the flag does not fix this issue.

Removing the modifier in RunScript seems to cause the target's attack animation to be reset, causing the next attack to be delayed longer than usual.