[BIN] argv now has command as first argument

Author: Diego Ferrari

bin/read/read.c

@@ -2,14 +2,14 @@
 
 int main(int argc, const char* argv[]){
     file fd2 = { .id = 2 };
-    if (argc < 1 || argc > 2){
+    if (argc < 2 || argc > 3){
         string err_msg = string_from_literal("Usage: read <path> [size]");
         writef(&fd2, err_msg.data, err_msg.length);
         free_sized(err_msg.data, err_msg.mem_length);
         return 2;
     }
-    const char* path = argv[0];
-    size_t size = argc < 2 ? 0 : parse_int_u64(argv[1], UINT32_MAX);
+    const char* path = argv[1];
+    size_t size = argc < 2 ? 0 : parse_int_u64(argv[2], UINT32_MAX);
     file fd = {};
     openf(path, &fd);
     if (fd.size == 0){

kernel/bin/bin_mod.c

@@ -73,7 +73,7 @@ process_t* execute(const char* prog_name, int argc, const char* argv[]){
                         for (int i = 0; i < argc; i++){
                             size_t strsize = strlen(argv[i]);
                             memcpy(nargvals + strptr, argv[i], strsize);
-                            *(char*)(nargvals + strptr + strsize) = 0;
+                            *(char*)(nargvals + strptr + strsize++) = 0;
                             nargv[i] = vnargvals + strptr;
                             strptr += strsize;
                         }

kernel/bin/monitor_processes.c

@@ -147,7 +147,7 @@ void draw_process_view(){
 
 int monitor_procs(int argc, char* argv[]){
     bool visual = false;
-    if (argc){ //TODO: make this a proper parser once argv is fixed
+    if (argc > 1){ //TODO: make this a proper parser once argv is fixed
         visual = true;
         request_draw_ctx(&ctx);
     }

utils/terminal/terminal.cpp

@@ -262,18 +262,17 @@ void Terminal::run_command(){
     const char** argv = nullptr;
     string args_copy = {};
 
-    if (*args == '\0'){
+    if (*args == '\0')
         cmd = string_from_literal(fullcmd);
-    } else {
-        size_t cmd_len = (size_t)(args - fullcmd);
-        cmd = string_from_literal_length(fullcmd, cmd_len);
-
-        const char* argstart = args;
-        while (*argstart == ' ' || *argstart == '\t') argstart++;
-
-        args_copy = string_from_literal(argstart);
-        argv = parse_arguments(args_copy.data, &argc);
-    }
+    else
+        cmd = string_from_literal_length(fullcmd, (size_t)(args - fullcmd));
+    
+    const char* argstart = fullcmd;
+    
+    while (*argstart && (*argstart == ' ' || *argstart == '\t')) argstart++;
+
+    args_copy = string_from_literal(argstart);
+    argv = parse_arguments(args_copy.data, &argc);
 
     if (!exec_cmd(cmd.data, argc, argv)){
         if (strcmp_case(cmd.data, "exit", true) == 0){