Skip to content

New version breaks compatibility with non-dask data #104

@stephenpardy

Description

@stephenpardy

Describe the issue:

Version 0.3.0 includes changes that break the compatibility of some functions - notably the families - to work with non-dask data.

As one example, the newton function changed the line calculating betas from:

beta = np.zeros_like(X, shape=p)

to:

beta = np.zeros_like(X._meta, shape=p)

which will fail for any non-dask data.

Minimal Complete Verifiable Example:

from dask_glm.algorithms import newton
import numpy as np
X = np.random.random((100, 3))
y = np.random.random((100,))
newton(X, y)

Anything else we need to know?: If this is an intended change, would be good to call out the reason for it (sorry if I missed it).

Environment: Local (macbook pro - M1)

  • Dask version: 2023.3.0
  • Python version: 3.10.10
  • Operating System: Mac osx
  • Install method (conda, pip, source): pip

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions