Selection module not functioning as expected

[brucewilliamsphotography]

Is there an existing issue for this?

• I checked and did not find my issue in the already reported ones

Describe the bug

Someone just posted on the darktable unofficial group in Farcebook about how the 'Selection module/Select untouched' button isn't functioning as expected.

Steps to reproduce

I've just checked with 5.4. Imported half a dozen images. Edited 2 of them (basic stuff like Col Bal RGB, etc), then selected 'Select untouched'. It de-selected all images, implying all images had been edited.
Have both of us misunderstood the purpose of that button?
I told him in the interim to use Collections/darktable/history/altered as a way to select his edited images for export.

Expected behavior

Would expect the 'select untouched' button to select images which the user has not actively edited.

Logfile | Screenshot | Screencast

No response

Commit

unknown

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

5.4

What OS are you using?

Linux

What is the version of your OS?

MX-23.6_x64 Libretto, 6.16.12-1-liquorix-amd64

Describe your system

No response

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

Device-1: NVIDIA GA104 [GeForce RTX 3070] vendor: ASUSTeK driver: nvidia v: 550.163.01 non-free: 530.xx+ status: current (as of 2023-03) arch: Ampere code: GAxxx process: TSMC n7 (7nm) built: 2020-22 pcie: gen: 1 speed: 2.5 GT/s lanes: 16 link-max: gen: 4 speed: 16 GT/s bus-ID: 27:00.0 chip-ID: 10de:2484 class-ID: 0300

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

[wpferguson]

I tested like this

Import a folder of images. Click select untouched and no images were selected, even though none of them had been touched. I checked the image flags and the altered flag wasn't set for any images.

I opened an image in darkroom. The default modules were applied. I closed the image and returned to lighttable. I clicked select untouched and the image I had opened in darkroom was selected. I checked the image flags and and the image showed as altered.

I looked at the history of common/selection.c and found where a change was made in 2023 to check the history hash to determine if the image was "untouched". I'm assuming that the change was made so that images that had the default modules applied, but no other edit, would still show up as untouched.

So we have another define what this means..... In this case it's define untouched. Is it

• just imported and never touched (unaltered)?
• had default modules applied but no other edit?
• both of the above, but if so how do you tell the difference?

Do we add another button select unaltered?

@TurboGit the 2023 change was yours, so perhaps you remember the reason for the change.

[wpferguson]

I whipped up a quick select_unaltered script that filters on the image is_altered flag. It works in the way I would expect for select untouched.

select_unaltered.lua.txt