Move Start, Stop and Initialise methods to the Extension interface#1
Open
dandm1 wants to merge 11 commits into
Open
Move Start, Stop and Initialise methods to the Extension interface#1dandm1 wants to merge 11 commits into
dandm1 wants to merge 11 commits into
Conversation
…so we have something common to hold on to.
…ied for Cumulus 3.
…y with abstract base class.
…lasses. Desparately need unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggest to move the Initialise, Start & Stop methods to the IExtension interface - there is a common way to interact with any sub-interface of Extension. I'm not sure how the ISettings classes to pass to Initialise will be created, but I assume there is some Dependency Injection magic that achieves this.