Feature request: `ghostel-copy-mode-copy` should not exit copy-mode

[jvillasante]

When reading logs it is useful to copy things to research in another emacs buffer but if I'm in copy-mode and press M-w after selecting something it not only copies but also exists copy-mode. This means I need to find my way back to where I was after the copy.

I can see how this is useful to others but users should at least have an option to just copy. In my case I have the below bindings and only want to exit copy-mode if I press RET:

:bind (("C-c o t" . ghostel)
              ("C-c o T" . my/ghostel-other-window)
              :map ghostel-copy-mode-map
              ("<return>" . ghostel-copy-mode-exit)
              ("RET"      . ghostel-copy-mode-exit)
              :map ghostel-mode-map
              ("M-[" . ghostel-copy-mode)
              :map project-prefix-map
              ("t" . ghostel-project)
              ("T" . my/ghostel-project-other-window))

[dakra]

I'm currently test driving the eat-input-modes branch PR #78
Once that is merged you have an option ghostel-readonly-fast-exit that toggles exactly what you asked.
Hope to merge this soon.
(if you want it now, you could even checkout that branch. it should be working fine. at max, maybe line-mode has some bugs still)

[jvillasante]

Nice, but note this is a departure of what vterm does. I guess most people that switch would like a similar experience. In vterm pressing M-w won't exit copy-mode...

[dakra]

Nice, but note this is a departure of what vterm does. I guess most people that switch would like a similar experience. In vterm pressing M-w won't exit copy-mode...

sure. but (a lot) of people asked for eat style input-mode.
Also I don't want to just copy vterm, I think ghostel is already way past that with a lot more features.
I think having the option to exit copy-mode "fast" like now with basically any keypress is imho a good default,
at least personally I mostly go into copy mode to copy one thing or just scroll through the scrollback and when I'm
done copying or want to type something, I find it convenient to immediately exit.
But it's configurable, so whatever the user prefers should work or course.

[jvillasante]

But it's configurable, so whatever the user prefers should work or course.

How is it configurable? When the new PR gets merged?

I'm done copying or want to type something

Good default for a terminal, not for a terminal inside Emacs where you want to copy into buffers, etc IMHO

[dakra]

How is it configurable? When the new PR gets merged?

yes. If you checkout that branch or wait until it's merged you can set ghostel-readonly-fast-exit to nil.

Good default for a terminal, not for a terminal inside Emacs where you want to copy into buffers, etc IMHO

I'm open to change the default of the ghostel-readonly-fast-exit setting. but not sure how to make a survey
for ghostel users.

[emil-e]

I personally prefer the defaults as they are - I like that typing always leads to input.

[jvillasante]

As they say, beauty is in the eye of the beholder!

The point I'm trying to raise is that this goes against Emacs defaults, regularity is important (there's a reason why I want a terminal inside Emacs, otherwise I would just use a real terminal).

Try shell-mode or eshell for example, after M-w on a region, the region is saved to the kill-ring, the mark is deactivated and the point stays at REGION-END, just as it is everywhere else in Emacs!

[dakra]

As they say, beauty is in the eye of the beholder!

True. And I appreciate the feedback.

The point I'm trying to raise is that this goes against Emacs defaults, regularity is important (there's a reason why I want a terminal inside Emacs, otherwise I would just use a real terminal).

Hopefully we can satisfy all needs. So you have your emacsy-terminal but also you never need to use a "real terminal" because ghostel is just that.. a real terminal.

Try shell-mode or eshell for example, after M-w on a region, the region is saved to the kill-ring, the mark is deactivated and the point stays at REGION-END, just as it is everywhere else in Emacs!

But shell or eshell don't have char or semi-char mode. So a fairer comparison would be the upcoming line-mode (also inside PR #78)
But we'll have a toggle option for copy-mode anyway, so everyone can have what they want :D