You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 28, 2019. It is now read-only.
In 7d9f44b, there were changes made to location handling. In particular, many parameters previously named location are now gherkinLocation (or bodyLocation, etc.). (This is great! It has made reading the code immensely easier to understand!)
Some of these changes also updated function signatures. I just noticed one: TestStep now has 4 arguments, where there used to be just 3.
However, the tests for TestStep still create instances with just 3 arguments. According to Travis, the tests all still pass. I’m not certain, but…I get the impression that the extra argument to create a new TestStep() was not supposed to be optional.
I recommend either:
fix the test: the test should be updated to use the 4 argument signature; OR
fix the object: the TestStep object should add a short comment explaining that the argument is optional (and what are the effects when it is not provided)
If the signatures are actually supposed to align, then perhaps something should be done so that things like this do not silently pass Travis CI.
In 7d9f44b, there were changes made to location handling. In particular, many parameters previously named
locationare nowgherkinLocation(orbodyLocation, etc.). (This is great! It has made reading the code immensely easier to understand!)Some of these changes also updated function signatures. I just noticed one:
TestStepnow has 4 arguments, where there used to be just 3.However, the tests for
TestStepstill create instances with just 3 arguments. According to Travis, the tests all still pass. I’m not certain, but…I get the impression that the extra argument to create a newTestStep()was not supposed to be optional.I recommend either:
TestStepobject should add a short comment explaining that the argument is optional (and what are the effects when it is not provided)If the signatures are actually supposed to align, then perhaps something should be done so that things like this do not silently pass Travis CI.