Documentation of ecocropPars #4
Description
I noticed a discrepancy between the documentation of ecocropPars() and its current implementation regarding how annual precipitation thresholds (RMIN, ROPMN, ROPMX, RMAX) are converted to monthly values.
The documentation states that monthly precipitation thresholds are obtained by dividing annual values by (growth duration in months + 1), and that growth duration is derived from GMIN. However, when looking at the code, I found that:
- both GMIN and GMAX are used to estimate growing-season length,
- four different divisors are derived and applied separately to RMIN, ROPMN, ROPMX, and RMAX,
- the effective duration is based on (GMIN + GMAX) / 2 (with a ±30-day adjustment), rather than GMIN + 1.
As a result, the documented approach does not reproduce the precipitation thresholds returned by ecocropPars().
It might be helpful to update the documentation to better reflect the current implementation.