It is confusing that without providing a dedicated port, we don't default to 4200 in all cases, e.g. when specifying to use TLS
e.g.
crash --hosts 'host' --> http://host:4200
crash --hosts 'http://host' --> http://host:80
crash --hosts 'https://host' --> https://host:443
crash --hosts 'https://host:4200' --> https://host:4200
they should all default to port 4200
crash --hosts 'host' --> http://host:4200
crash --hosts 'http://host' --> http://host:4200
crash --hosts 'https://host' --> https://host:4200
crash --hosts 'https://host:4200' --> https://host:4200
This probably will need some improvement here as we just split : 🙈
|
if ':' in host_or_port: |
|
if len(host_or_port) == 1: |
|
return 'localhost:4200' |
|
elif host_or_port.startswith(':'): |
|
return 'localhost' + host_or_port |
|
return host_or_port |
|
return host_or_port + ':4200' |
It is confusing that without providing a dedicated port, we don't default to 4200 in all cases, e.g. when specifying to use TLS
e.g.
they should all default to port 4200
This probably will need some improvement here as we just split
:🙈crash/crate/crash/command.py
Lines 530 to 536 in 76e3637