refactor: use health.ProbeDir; drop duplicated probe#67
Closed
cplieger wants to merge 1 commit into
Closed
Conversation
cplieger
force-pushed
the
refactor/health-probedir
branch
from
191ba70 to
79c1494
Compare
Open
Owner
Author
|
Superseded by #72 ("Library adoption"), which consolidates this app's health (and httpx where applicable) library adoption into a single PR for one merge + one build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse
health.goto a thin alias: remove the copiedprobeHealthDirand the deaddegradedfield/struct wrapper (the library handles degraded mode internally); tests now usehealth.ProbeDir. No prod behavior change (default mode=server, marker stays live). Stacked onrefactor/module-domain-path.ProbeDir). Release health v1.1.0 first, then bump thegithub.com/cplieger/healthrequire to v1.1.0 here +go mod tidy. CI is red until then; verified locally via go.work.