CXXCBC-810: Fix transactions layer and add unit tests#930
Open
avsej wants to merge 1 commit into
Open
Conversation
Member
avsej
commented
Mar 27, 2026
avsej
commented
- Replace implicit couchbase::error{} brace-init with explicit constructor calls
- Fix FAIL_DOC_NOT_FOUND misuse in transaction_operation_failed()
- Return std::string_view from staged_mutation::type_as_string()
- Replace std::lock_guard with std::scoped_lock throughout
- Add error_class_from_response specialization for lookup_in_response
- Fix missing transactions_config move-assignment operator
- Add unit tests: error_class_from_response, atr_entry::has_expired, type_as_string
- Add Doxygen comments to affected functions
avsej
added
help wanted
avsej
force-pushed
the
fix/cxxcbc-810-transactions-explicit-error-init-scoped-lock-fail-doc-not-found
branch
from
79ae6ea to
fc9ad2d
Compare
- Replace implicit couchbase::error{} brace-init with explicit constructor calls
- Fix FAIL_DOC_NOT_FOUND misuse in transaction_operation_failed()
- Return std::string_view from staged_mutation::type_as_string()
- Replace std::lock_guard with std::scoped_lock throughout
- Add error_class_from_response specialization for lookup_in_response
- Fix missing transactions_config move-assignment operator
- Add unit tests: error_class_from_response, atr_entry::has_expired, type_as_string
- Add Doxygen comments to affected functions
avsej
force-pushed
the
fix/cxxcbc-810-transactions-explicit-error-init-scoped-lock-fail-doc-not-found
branch
from
fc9ad2d to
46f4cf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.