Skip to content

Commit a135e8e

Browse files
committed
Remove WORKAROUND_ISSUE_622
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
1 parent a8a9c5d commit a135e8e

2 files changed

Lines changed: 3 additions & 20 deletions

File tree

.github/workflows/test.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -288,18 +288,10 @@ jobs:
288288
--output=type=docker \
289289
--cache-from type=gha,scope=${ARCH}-${CONTAINERD_VERSION} \
290290
-t ${TEST_TARGET} --target ${TEST_TARGET} --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} --build-arg CONTAINERD_VERSION=${CONTAINERD_VERSION} --build-arg ROOTLESSKIT_VERSION=${ROOTLESSKIT_VERSION} .
291-
- name: "Disable BuildKit for RootlessKit v1 (workaround for issue #622)"
292-
run: |
293-
# https://github.com/containerd/nerdctl/issues/622
294-
WORKAROUND_ISSUE_622=
295-
if echo "${ROOTLESSKIT_VERSION}" | grep -q v1; then
296-
WORKAROUND_ISSUE_622=1
297-
fi
298-
echo "WORKAROUND_ISSUE_622=${WORKAROUND_ISSUE_622}" >> "$GITHUB_ENV"
299291
- name: "Test (network driver=slirp4netns, port driver=builtin)"
300-
run: docker run -t --rm --privileged -e WORKAROUND_ISSUE_622=${WORKAROUND_ISSUE_622} ${TEST_TARGET} /test-integration-rootless.sh ./hack/test-integration.sh -test.only-flaky=false
292+
run: docker run -t --rm --privileged ${TEST_TARGET} /test-integration-rootless.sh ./hack/test-integration.sh -test.only-flaky=false
301293
- name: "Test (network driver=slirp4netns, port driver=builtin) (flaky)"
302-
run: docker run -t --rm --privileged -e WORKAROUND_ISSUE_622=${WORKAROUND_ISSUE_622} ${TEST_TARGET} /test-integration-rootless.sh ./hack/test-integration.sh -test.only-flaky=true
294+
run: docker run -t --rm --privileged ${TEST_TARGET} /test-integration-rootless.sh ./hack/test-integration.sh -test.only-flaky=true
303295

304296
build:
305297
timeout-minutes: 5

Dockerfile.d/test-integration-rootless.sh

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@ if [[ "$(id -u)" = "0" ]]; then
2525
nerdctl apparmor load
2626
fi
2727

28-
: "${WORKAROUND_ISSUE_622:=}"
29-
if [[ "$WORKAROUND_ISSUE_622" = "1" ]]; then
30-
touch /workaround-issue-622
31-
fi
32-
3328
# Switch to the rootless user via SSH
3429
systemctl start ssh
3530
exec ssh -o StrictHostKeyChecking=no rootless@localhost "$0" "$@"
@@ -39,11 +34,7 @@ else
3934
containerd-rootless-setuptool.sh nsenter -- sh -euc 'echo "options use-vc" >>/etc/resolv.conf'
4035
fi
4136

42-
if [[ -e /workaround-issue-622 ]]; then
43-
echo "WORKAROUND_ISSUE_622: Not enabling BuildKit (https://github.com/containerd/nerdctl/issues/622)" >&2
44-
else
45-
CONTAINERD_NAMESPACE="nerdctl-test" containerd-rootless-setuptool.sh install-buildkit-containerd
46-
fi
37+
CONTAINERD_NAMESPACE="nerdctl-test" containerd-rootless-setuptool.sh install-buildkit-containerd
4738
containerd-rootless-setuptool.sh install-stargz
4839
if [ ! -f "/home/rootless/.config/containerd/config.toml" ] ; then
4940
echo "version = 2" > /home/rootless/.config/containerd/config.toml

0 commit comments

Comments
 (0)