Skip to content

Reconcile time and elapsed_time variables #202

@jcurtis2

Description

@jcurtis2

In the output, we have two variables that describe time:

    double time ;
            time:unit = "s" ;
            time:description = "time elapsed since simulation start" ;
    double elapsed_time ;
            elapsed_time:unit = "s" ;
            elapsed_time:description = "elapsed time since simulation start" ;

And while these are the same in an initial simulation, they are actually different in a restart simulation where elapsed_time would be the correct time and time is reset to 0 as it appears to be used for a counter for when to do output. Therefore time isn't actually time elapsed since simulation start (and probably shouldn't be used for anything or necessarily output).

Example from urban_plume_0001_00000001.nc when restarted from out_init/urban_plume_0001_00000022.nc

 time = 0 ;
 elapsed_time = 75600 ;

where in out_init/urban_plume_0001_00000022.nc:

 time = 75600 ;
 elapsed_time = 75600 ;

Relevant code:

time = 0d0

t_start = env_state%elapsed_time

call scenario_update_env_state(scenario, env_state, time + t_start)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions