Replace PR references in e2e test comments with self-contained descriptions

Author: conatus

packages/join-e2e/tests/04-donation-upsell.spec.ts

@@ -2,12 +2,14 @@ import { test, expect } from '@playwright/test';
 import { mockRestEndpoints, CONTINUE } from './helpers';
 
 /**
- * Phase 4 — Donation upsell (standard join flow with ASK_FOR_ADDITIONAL_DONATION on)
+ * Phase 4 — Donation upsell
  *
- * PR #59 test plan sections 2, 3, 4.
+ * Tests the standard join flow when ASK_FOR_ADDITIONAL_DONATION is enabled.
+ * After the member selects a plan, an optional donation upsell page is shown
+ * before the payment step. Members can choose an amount, optionally make it
+ * recurring, or skip the donation entirely with "Not right now".
  *
  * Config: ASK_FOR_ADDITIONAL_DONATION=true, DONATION_SUPPORTER_MODE=false.
- * The upsell donation page appears after plan selection.
  *
  * All REST endpoints are mocked. The bundle is built with USE_TEST_DATA=true
  * so all personal-detail fields are pre-filled.

packages/join-e2e/tests/05-supporter-mode-monthly.spec.ts

@@ -4,11 +4,16 @@ import { mockRestEndpoints, captureJoinBodyViaStripeRedirect, injectEnvOverrides
 /**
  * Phase 5 — Supporter mode, monthly donations
  *
- * PR #59 test plan sections 5 and 7.
+ * Tests the Donation Supporter Mode flow where the donation step comes first
+ * (before personal details and payment). Members choose a giving tier or enter
+ * a custom amount, with monthly recurring selected by default.
  *
- * Config: DONATION_SUPPORTER_MODE=true, USE_STRIPE=true (injected).
- * The donation page is the FIRST step (not the details page).
- * Monthly frequency is selected by default.
+ * Covers: first-step rendering, tier/custom-amount CTA updates, advancing
+ * through donation → details, and the /join request body for a monthly
+ * recurring supporter donation (donationAmount=0 because the plan price IS
+ * the donation; recurDonation=true).
+ *
+ * Config: DONATION_SUPPORTER_MODE=true, USE_STRIPE=true (injected via env override).
  */
 
 const SUPPORTER_PAGE = '/e2e-supporter/';
@@ -101,8 +106,8 @@ test.describe('5.5 — /join body for monthly supporter donation', () => {
   });
 });
 
-test.describe('5.6 — Product naming: Donation prefix for supporter mode', () => {
-  test('/join body membership starts with the plan value (not "Membership:")', async ({ page }) => {
+test.describe('5.6 — Product naming: supporter mode produces a Donation product', () => {
+  test('/join body signals a recurring supporter donation (recurDonation=true, donationAmount=0)', async ({ page }) => {
     await page.locator('button:has-text("£5")').click();
     await page.locator('button[type="submit"]').click();
     await page.waitForSelector('input#firstName');
@@ -118,10 +123,10 @@ test.describe('5.6 — Product naming: Donation prefix for supporter mode', () =
 });
 
 // ---------------------------------------------------------------------------
-// Section 7 — Custom amount
+// Custom amount (plan with allow_custom_amount enabled)
 // ---------------------------------------------------------------------------
 
-test.describe('5.7 — Custom amount updates CTA (PR #59 section 7)', () => {
+test.describe('5.7 — Custom amount updates CTA', () => {
   test('entering a custom amount updates CTA to reflect the custom value', async ({ page }) => {
     await injectEnvOverrides(page, `**${SUPPORTER_CUSTOM_PAGE}`, { USE_STRIPE: true });
     await mockRestEndpoints(page);

packages/join-e2e/tests/06-supporter-mode-oneoff.spec.ts

@@ -4,17 +4,20 @@ import { mockRestEndpoints, captureJoinBodyViaStripeRedirect, injectEnvOverrides
 /**
  * Phase 6 — Supporter mode, one-off donations
  *
- * PR #59 test plan sections 8 and 8a.
+ * Tests the one-off donation path within Supporter Mode. When Stripe card
+ * payments are available (USE_STRIPE=true, STRIPE_DIRECT_DEBIT_ONLY=false),
+ * the One-off tab is enabled. Selecting it changes the CTA to "Donate £X now"
+ * (no "/month" suffix) and sets paymentMethod to creditCard.
  *
- * Config: DONATION_SUPPORTER_MODE=true, USE_STRIPE=true, STRIPE_DIRECT_DEBIT_ONLY=false.
- * The One-off tab must be enabled and selecting it changes the CTA to "Donate £X now".
+ * Because Stripe does not create a subscription for one-off donations, the
+ * proxy assertion used here is the /join request body:
+ *   - recurDonation: false  — the frontend signals a one-off intent
+ *   - donationAmount: N     — the PaymentIntent amount (not 0)
+ * The backend routes this through createPaymentIntent rather than a
+ * subscription, which is the equivalent server-side check.
  *
- * Verifying "no subscription created" in Stripe is not possible without live
- * credentials. As a proxy, the /join request body is inspected:
- *   - recurDonation: false  → the frontend signals a one-off intent
- *   - donationAmount: N     → the amount for the PaymentIntent (not 0)
- * The backend routes this through createPaymentIntent rather than creating a
- * subscription, which is the equivalent server-side assertion.
+ * Config: DONATION_SUPPORTER_MODE=true, USE_STRIPE=true, STRIPE_DIRECT_DEBIT_ONLY=false
+ * (all injected via env override since these are global plugin settings).
  */
 
 const SUPPORTER_PAGE = '/e2e-supporter/';
@@ -60,7 +63,7 @@ test.describe('6.2 — Selecting One-off updates CTA', () => {
   });
 });
 
-test.describe('6.3 — /join body for one-off supporter donation (PR #59 section 8)', () => {
+test.describe('6.3 — /join body for one-off supporter donation', () => {
   test('recurDonation=false and donationAmount>0 in /join body for one-off', async ({ page }) => {
     await loadSupporterPage(page);
 
@@ -95,7 +98,7 @@ test.describe('6.3 — /join body for one-off supporter donation (PR #59 section
   });
 });
 
-test.describe('6.4 — One-off custom amount (PR #59 section 8a)', () => {
+test.describe('6.4 — One-off custom amount', () => {
   test('custom amount on one-off updates CTA to "Donate £X now"', async ({ page }) => {
     await injectEnvOverrides(page, `**${SUPPORTER_CUSTOM_PAGE}`, {
       USE_STRIPE: true,

packages/join-e2e/tests/07-supporter-mode-edge-cases.spec.ts

@@ -4,19 +4,26 @@ import { mockRestEndpoints, captureJoinBodyViaStripeRedirect, injectEnvOverrides
 /**
  * Phase 7 — Supporter mode edge cases and product naming
  *
- * PR #59 test plan sections 9, 10, and 13.
+ * One-off tab disabled when Direct Debit Only is active:
+ *   When STRIPE_DIRECT_DEBIT_ONLY=true, the One-off tab is disabled and an
+ *   explanatory note is shown. Monthly donations remain available.
  *
- * Section 9:  One-off tab disabled when STRIPE_DIRECT_DEBIT_ONLY=true.
- * Section 10: No plans configured shows a warning.
- * Section 13: Product naming — /join request body carries the correct
- *             membership value prefix for standard vs supporter mode.
+ * No plans configured:
+ *   When a Supporter Mode block has no membership plans set, the donation page
+ *   shows a "No donation amounts configured" warning instead of tier buttons.
  *
- * Note: Section 11 (free membership) is already covered by Phase 3
- * (03-free-membership.spec.ts). Section 12 (Mailchimp non-fatal errors)
- * is a backend concern verified by PHP unit tests; the frontend always
- * receives success:true regardless of Mailchimp state.
- * Section 6 (supporter mode monthly via Direct Debit) requires a live
- * GoCardless integration and is covered by manual testing.
+ * Product naming in /join request body:
+ *   - Standard join: membership field holds a plan ID (not prefixed "Donation:").
+ *     The backend names the Stripe product "Membership: <plan label>".
+ *   - Supporter mode monthly: recurDonation=true and donationAmount=0 signal
+ *     that the plan price IS the donation; backend names it "Donation: <label>".
+ *   - Supporter mode one-off: recurDonation=false and donationAmount>0 signal
+ *     a one-time PaymentIntent; backend uses the "Supporter Donation" product.
+ *
+ * Note: Free membership (payment skipped for zero-price plans) is covered by
+ * Phase 3 (03-free-membership.spec.ts). Mailchimp non-fatal error handling is
+ * a backend concern covered by JoinServiceMailchimpTest.php. Supporter mode
+ * monthly via Direct Debit requires a live GoCardless integration.
  */
 
 const SUPPORTER_PAGE = '/e2e-supporter/';
@@ -27,7 +34,7 @@ const STANDARD_PAGE = '/e2e-standard-join/';
 // Section 9 — One-off disabled when Direct Debit only
 // ---------------------------------------------------------------------------
 
-test.describe('7.1 — One-off tab disabled when STRIPE_DIRECT_DEBIT_ONLY=true (PR #59 section 9)', () => {
+test.describe('7.1 — One-off tab disabled when STRIPE_DIRECT_DEBIT_ONLY=true', () => {
   test.beforeEach(async ({ page }) => {
     await injectEnvOverrides(page, `**${SUPPORTER_PAGE}`, {
       USE_STRIPE: true,
@@ -64,7 +71,7 @@ test.describe('7.1 — One-off tab disabled when STRIPE_DIRECT_DEBIT_ONLY=true (
 // Section 10 — No plans configured
 // ---------------------------------------------------------------------------
 
-test.describe('7.2 — No plans configured warning (PR #59 section 10)', () => {
+test.describe('7.2 — No plans configured warning', () => {
   test.beforeEach(async ({ page }) => {
     await injectEnvOverrides(page, `**${SUPPORTER_NO_PLANS_PAGE}`, { USE_STRIPE: true });
     await mockRestEndpoints(page);
@@ -87,7 +94,7 @@ test.describe('7.2 — No plans configured warning (PR #59 section 10)', () => {
 // Section 13 — Product naming
 // ---------------------------------------------------------------------------
 
-test.describe('7.3 — Product naming: standard join (PR #59 section 13)', () => {
+test.describe('7.3 — Product naming: standard join', () => {
   test('/join body membership does not contain "Donation:" prefix for standard join', async ({ page }) => {
     await injectEnvOverrides(page, `**${STANDARD_PAGE}`, { USE_STRIPE: true });
     await mockRestEndpoints(page);
@@ -110,7 +117,7 @@ test.describe('7.3 — Product naming: standard join (PR #59 section 13)', () =>
   });
 });
 
-test.describe('7.4 — Product naming: supporter mode monthly (PR #59 section 13)', () => {
+test.describe('7.4 — Product naming: supporter mode monthly', () => {
   test('/join body signals a recurring donation (recurDonation=true, donationAmount=0)', async ({ page }) => {
     await injectEnvOverrides(page, `**${SUPPORTER_PAGE}`, {
       USE_STRIPE: true,
@@ -136,7 +143,7 @@ test.describe('7.4 — Product naming: supporter mode monthly (PR #59 section 13
   });
 });
 
-test.describe('7.5 — Product naming: supporter mode one-off (PR #59 section 13)', () => {
+test.describe('7.5 — Product naming: supporter mode one-off', () => {
   test('/join body signals a one-off donation (recurDonation=false, donationAmount>0)', async ({ page }) => {
     await injectEnvOverrides(page, `**${SUPPORTER_PAGE}`, {
       USE_STRIPE: true,