Feature request: allow hex/base64 input and remove reference to window object

[mackwil]

Hi,
I have two small feature requests:

1. Can you allow an input parameter to specify whether the input is text, hex or base64? I want to use the HMAC function with a key that consists of random bits, therefore converting those bits to hex or base64 first is the norm before inputting into the HMAC function. Another library already allows this, jsSHA, but they do not have the Skein function. Perhaps you could imitate how they do it?

2. Can you remove references to the window object and just allow the user to instantiate the library. This means your library will work inside a web worker and the hashing can be done without blocking the user interface. Web Workers will fail if they try to reference the window object.

Thankyou!

[coiscir]

1. I don't see these currently fitting well into the hash functions themselves, with the arguments they have already.

   Though, a 2nd argument could be added to Digest.toBuffer(). (It isn't mentioned in the docs, but is meant to be a "public" function.)

   Digest.skein(data, Digest.toBuffer(randomBits, 'hex')).hex()
   

   Both data and key accept "buffers" – Arrays or array-like objects containing numbers (0-255) – and Digest.toBuffer() currently covers 'text' implicitly.

   Digest.skein(Digest.toBuffer('abc')).hex() === Digest.skein('abc').hex()
   // true
   

   You can also use your own function:

   Digest.skein(data, parseHex(randomBits)).hex();
   

   ---

   Also, side note regarding:

   I want to use the HMAC function with a key that consists of random bits, therefore converting those bits to hex or base64 first [..]

   If the random bits are returned in a collection similar to a "buffer," you could skip "converting those bits to hex or base64 first" or using Digest.toBuffer().

   var randomBits = generateBits();
   var hash = Digest.skein('data', randomBits).hex();