From 23368632ca142e260556a6850d68bb9640a2c4a9 Mon Sep 17 00:00:00 2001 From: Scott Bale Date: Tue, 30 Sep 2025 15:48:38 -0300 Subject: [PATCH 1/2] Use official minio image for integration tests --- .github/workflows/test.yml | 3 ++- test/src/cognitect/aws/integration/s3_test.cljc | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 83c0bf92..b9f6dce9 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -20,9 +20,10 @@ jobs: services: s3: - image: bitnami/minio + image: minio/minio ports: - 9000:9000 + options: server /data steps: - name: Checkout repository diff --git a/test/src/cognitect/aws/integration/s3_test.cljc b/test/src/cognitect/aws/integration/s3_test.cljc index 80dc09b8..71b7b5f0 100644 --- a/test/src/cognitect/aws/integration/s3_test.cljc +++ b/test/src/cognitect/aws/integration/s3_test.cljc @@ -117,8 +117,8 @@ :hostname "localhost" :port 9000} :credentials-provider (creds/basic-credentials-provider - {:access-key-id "minio" - :secret-access-key "miniosecret"})})] + {:access-key-id "minioadmin" + :secret-access-key "minioadmin"})})] (testing (str "with http client " (class %)) (test-s3-client s3))))) From 405492587768af5e3153cd4ed5d8a44bcc17ada8 Mon Sep 17 00:00:00 2001 From: Scott Bale Date: Tue, 30 Sep 2025 15:58:15 -0300 Subject: [PATCH 2/2] args instead of options - Use official minio image for integration tests --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b9f6dce9..9200f309 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -23,7 +23,7 @@ jobs: image: minio/minio ports: - 9000:9000 - options: server /data + args: ["server", "/data"] steps: - name: Checkout repository