From 1a9479653be111e5d26153945848ef4e8d51e16b Mon Sep 17 00:00:00 2001
From: OpenGHz <1352674740@qq.com>
Date: Thu, 13 Mar 2025 06:55:28 +0000
Subject: [PATCH 1/2] fix missing mimic tags

---
 src/yourdfpy/urdf.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/yourdfpy/urdf.py b/src/yourdfpy/urdf.py
index eb479ad..2946d58 100644
--- a/src/yourdfpy/urdf.py
+++ b/src/yourdfpy/urdf.py
@@ -1483,6 +1483,8 @@ def _parse_mimic(xml_element):
         )
 
     def _write_mimic(self, xml_parent, mimic):
+        if mimic is None:
+            return
         etree.SubElement(
             xml_parent,
             "mimic",
@@ -2153,6 +2155,7 @@ def _write_joint(self, xml_parent, joint):
         self._write_origin(xml_element, joint.origin)
         self._write_axis(xml_element, joint.axis)
         self._write_limit(xml_element, joint.limit)
+        self._write_mimic(xml_element, joint.mimic)
         self._write_dynamics(xml_element, joint.dynamics)
 
     @staticmethod

From d00a0d8604c08901321467f1ba7820797e48d9bd Mon Sep 17 00:00:00 2001
From: OpenGHz <1352674740@qq.com>
Date: Thu, 13 Mar 2025 07:31:44 +0000
Subject: [PATCH 2/2] add load and write ros2_control tags

---
 src/yourdfpy/urdf.py | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/yourdfpy/urdf.py b/src/yourdfpy/urdf.py
index 2946d58..97ed38b 100644
--- a/src/yourdfpy/urdf.py
+++ b/src/yourdfpy/urdf.py
@@ -4,7 +4,7 @@
 import logging
 import numpy as np
 from dataclasses import dataclass, field, is_dataclass
-from typing import Dict, List, Optional, Union
+from typing import Dict, List, Optional, Union, Any
 from functools import partial
 
 import trimesh
@@ -318,6 +318,7 @@ class Robot:
     materials: List[Material] = field(default_factory=list)
     transmission: List[str] = field(default_factory=list)
     gazebo: List[str] = field(default_factory=list)
+    ros2_controls: List[Any] = field(default_factory=list)
 
     def __eq__(self, other):
         if not isinstance(other, Robot):
@@ -2158,6 +2159,14 @@ def _write_joint(self, xml_parent, joint):
         self._write_mimic(xml_element, joint.mimic)
         self._write_dynamics(xml_element, joint.dynamics)
 
+    def _parse_ros2_control(xml_element):
+        return xml_element
+
+    def _write_ros2_control(self, xml_parent, ros2_control):
+        if ros2_control is None:
+            return
+        xml_parent.append(ros2_control)
+
     @staticmethod
     def _parse_robot(xml_element):
         robot = Robot(name=xml_element.attrib["name"])
@@ -2168,6 +2177,8 @@ def _parse_robot(xml_element):
             robot.joints.append(URDF._parse_joint(j))
         for m in xml_element.findall("material"):
             robot.materials.append(URDF._parse_material(m))
+        for c in xml_element.findall("ros2_control"):
+            robot.ros2_controls.append(URDF._parse_ros2_control(c))
         return robot
 
     def _validate_robot(self, robot):
@@ -2191,6 +2202,8 @@ def _write_robot(self, robot):
             self._write_joint(xml_element, joint)
         for material in robot.materials:
             self._write_material(xml_element, material)
+        for ros2_control in robot.ros2_controls:
+            self._write_ros2_control(xml_element, ros2_control)
 
         return xml_element