Skip to content

chore: improve ebpf maintenance path #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
otjdiepluong wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −5
Open

chore: improve ebpf maintenance path #2020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions info_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,16 +357,21 @@ func TestProgramInfoMapIDsNoMaps(t *testing.T) {
func TestScanFdInfoReader(t *testing.T) {
tests := []struct {
fields map[string]any
input string
valid bool
}{
{nil, true},
{map[string]any{"foo": new(string)}, true},
{map[string]any{"zap": new(string)}, false},
{map[string]any{"foo": new(int)}, false},
{nil, "foo:\tbar\n", true},
{map[string]any{"foo": new(string)}, "foo:\tbar\n", true},
{map[string]any{"zap": new(string)}, "foo:\tbar\n", false},
{map[string]any{"foo": new(int)}, "foo:\tbar\n", false},
// Empty fdinfo can occur in restricted container environments.
{map[string]any{"foo": new(string)}, "", false},
// Lines without a colon are skipped.
{map[string]any{"foo": new(string)}, "no colon here\n", false},
}

for _, test := range tests {
err := scanFdInfoReader(strings.NewReader("foo:\tbar\n"), test.fields)
err := scanFdInfoReader(strings.NewReader(test.input), test.fields)
if test.valid {
if err != nil {
t.Errorf("fields %v returns an error: %s", test.fields, err)
Expand Down