Skip to content

options first in pod constructor #10

@jonyrock

Description

@jonyrock

I believe that options should be first in the constructor here

abstract class ChartwerkPod<T extends TimeSerie, O extends Options> {
  // ...

  constructor(
    // maybe it's not the best idea
    _d3: typeof d3,
    protected readonly el: HTMLElement,
    protected readonly series: T[] = [],
    _options: O
  ) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions