Error in update method (get_mgds)

[GLHolliday79]

There appears to be an issue with the update method, specifically in the get_mgds method. At least one of the mgd ids appears to be simply "M" which causes the code to fall over.

Line 187 in database.py. I solved this by:

def get_mgds(self, hgnc):
    mgds = []

    if 'mgd_id' in hgnc:

        for mgd in hgnc['mgd_id']:

            if mgd not in self.mgds:
                try:
                    mgdid = int(mgd.split(':')[-1])
                except ValueError:
                    mgdid = None
                if mgdid:
                    self.mgds[mgd] = models.MGD(mgdid=mgdid)
                    mgds.append(self.mgds[mgd])

    return mgds

However, I'm not sure if the real issue is in the download or not.

[bgriffen]

Indeed, there is an error whilst running pyhgnc.update().

File ~/miniforge3/lib/python3.8/site-packages/pyhgnc/manager/database.py:195, in DbManager.get_mgds(self, hgnc)
    192 for mgd in hgnc['mgd_id']:
    194     if mgd not in self.mgds:
--> 195         mgdid = int(mgd.split(':')[-1])
    196         self.mgds[mgd] = models.MGD(mgdid=mgdid)
    198     mgds.append(self.mgds[mgd])

ValueError: invalid literal for int() with base 10: ''

Happens on multiple systems, versions and OSs. Indeed the work around by @GLHolliday79 works! Thanks.