Skip to content

Make private methods protected #49

@colinmollenhour

Description

@colinmollenhour

Thanks for your work on this library, Christian!

What are your thoughts on replacing all private method declarations with protected?

We're having a strange issue where some XML responses from Amazon are partially corrupt, like XML tags that are combined with each other, nested incorrectly, etc. Since the Amazon library only returns the parsed XML and not the raw response text we can't log this to see exactly what is getting returned and since it uses private methods we can't easily override the Amazon code to inject our logger code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions