From 264490aa7c6eb2ecb896fcdd7e91779dacd45b49 Mon Sep 17 00:00:00 2001 From: Brian Love Date: Wed, 20 May 2026 08:13:02 -0700 Subject: [PATCH 1/2] =?UTF-8?q?fix(chat):=20rename=20chat-sidenav-scrim=20?= =?UTF-8?q?output=20close=20=E2=86=92=20dismiss?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `close` is a standard DOM event name, which triggers @angular-eslint/no-output-native and fails Library lint CI. Renames the EventEmitter to `dismiss`, updates the only consumer (examples/chat/angular demo shell) and the component spec + docstring. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../chat/angular/src/app/shell/demo-shell.component.html | 2 +- .../chat-sidenav-scrim.component.spec.ts | 8 ++++---- .../chat-sidenav-scrim/chat-sidenav-scrim.component.ts | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/chat/angular/src/app/shell/demo-shell.component.html b/examples/chat/angular/src/app/shell/demo-shell.component.html index e8402678..f54650af 100644 --- a/examples/chat/angular/src/app/shell/demo-shell.component.html +++ b/examples/chat/angular/src/app/shell/demo-shell.component.html @@ -60,7 +60,7 @@ { expect(btn.getAttribute('aria-label')).toBe('Close conversations'); }); - it('emits (close) on click', () => { + it('emits (dismiss) on click', () => { fx.componentRef.setInput('open', true); fx.detectChanges(); - let closed = false; - fx.componentInstance.close.subscribe(() => { closed = true; }); + let dismissed = false; + fx.componentInstance.dismiss.subscribe(() => { dismissed = true; }); const btn = fx.nativeElement.querySelector('button.chat-sidenav-scrim__button') as HTMLButtonElement; btn.click(); - expect(closed).toBe(true); + expect(dismissed).toBe(true); }); }); diff --git a/libs/chat/src/lib/primitives/chat-sidenav-scrim/chat-sidenav-scrim.component.ts b/libs/chat/src/lib/primitives/chat-sidenav-scrim/chat-sidenav-scrim.component.ts index 41d107f0..33feaeb3 100644 --- a/libs/chat/src/lib/primitives/chat-sidenav-scrim/chat-sidenav-scrim.component.ts +++ b/libs/chat/src/lib/primitives/chat-sidenav-scrim/chat-sidenav-scrim.component.ts @@ -8,7 +8,7 @@ import { ChangeDetectionStrategy, Component, input, output } from '@angular/core * and the drawer host (escapes the drawer host's stacking context). * * Usage: - * + * * */ @Component({ @@ -21,7 +21,7 @@ import { ChangeDetectionStrategy, Component, input, output } from '@angular/core type="button" class="chat-sidenav-scrim__button" aria-label="Close conversations" - (click)="close.emit()" + (click)="dismiss.emit()" > } `, @@ -44,5 +44,5 @@ export class ChatSidenavScrimComponent { /** When true, render the backdrop button covering the viewport. */ readonly open = input(false); /** Fires when the user clicks the backdrop. */ - readonly close = output(); + readonly dismiss = output(); } From 4c44559a1b396ac41a9f88b1bc811f90468e7e8b Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 20 May 2026 15:15:11 +0000 Subject: [PATCH 2/2] chore(docs): regenerate api docs --- apps/website/content/docs/chat/api/api-docs.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/website/content/docs/chat/api/api-docs.json b/apps/website/content/docs/chat/api/api-docs.json index 1b0201a4..324d4f9c 100644 --- a/apps/website/content/docs/chat/api/api-docs.json +++ b/apps/website/content/docs/chat/api/api-docs.json @@ -3414,12 +3414,12 @@ { "name": "ChatSidenavScrimComponent", "kind": "class", - "description": "Backdrop scrim for chat-sidenav's drawer mode, rendered as a sibling of\n so its z-index sits cleanly between the page content\nand the drawer host (escapes the drawer host's stacking context).\n\nUsage:\n \n ", + "description": "Backdrop scrim for chat-sidenav's drawer mode, rendered as a sibling of\n so its z-index sits cleanly between the page content\nand the drawer host (escapes the drawer host's stacking context).\n\nUsage:\n \n ", "params": [], "examples": [], "properties": [ { - "name": "close", + "name": "dismiss", "type": "OutputEmitterRef", "description": "Fires when the user clicks the backdrop.", "optional": false