Commit 2da4f47
test(e2e-harness): delete broken test-helpers.spec.ts; document strategy (#499)
The spec imported `SendPromptAndWaitOptions` which was removed in PR #472
(harness helper consolidation), leaving a tsc error in the lint target
that has been silently failing the Library — lint gate. The chat-sidenav-
scrim no-output-native noise (resolved by #485) was masking it; subsequent
admin-merges let it through.
Two-part fix:
1. Delete the spec. Its original purpose ("locks in the type contract")
was already covered by tsc itself; the deleted type meant the spec
was just verifying a removed API.
2. Document the testing strategy in a header block on test-helpers.ts
so future contributors know the absence of unit tests is intentional:
- The 3 Playwright-dependent helpers are exercised end-to-end by the
24 cockpit cap aimock e2es in the matrix.
- `startAimock` (the only helper testable without a Page) has its own
aimock-runner.spec.ts in the same directory.
Identified during the post-Task-#4 e2e audit (item #8).
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 7aeb2eb commit 2da4f47
2 files changed
Lines changed: 16 additions & 18 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
2 | 18 | | |
3 | 19 | | |
4 | 20 | | |
| |||
0 commit comments