fix: aws s3 support instance role (#21)

XiaoHei · pengyu.liu · web-flow · commit 91c97150faea · 2024-12-20T11:19:43.000+08:00
Co-authored-by: pengyu.liu &lt;pengyu.liu@ewp-group.com&gt;
diff --git a/cloud/common.go b/cloud/common.go
@@ -84,10 +84,11 @@ func (option AWSOption) Check() error {
 	}
 	validKeyConfig := option.SecretID != "" && option.SecretKey != ""
 	validAssumeRoleConfig := option.AssumeRoleArn != "" && option.AssumeRegion != ""
-	if !validKeyConfig && !validAssumeRoleConfig {
-		return errors.New("must have valid key pairs config or assume role config")
+	validInstanceRoleConfig := option.AssumeRoleArn == "" && option.AssumeRegion == "" && option.SecretID == "" && option.SecretKey == ""
+	if validKeyConfig || validAssumeRoleConfig || validInstanceRoleConfig {
+		return nil
 	}
-	return nil
+	return errors.New("must have valid key pairs config or assume role config")
 }
 
 type CommonOption struct {

Original file line number	Diff line number	Diff line change
`@@ -84,10 +84,11 @@ func (option AWSOption) Check() error {`
`84`	`84`	`}`
`85`	`85`	`validKeyConfig := option.SecretID != "" && option.SecretKey != ""`
`86`	`86`	`validAssumeRoleConfig := option.AssumeRoleArn != "" && option.AssumeRegion != ""`
`87`		`- if !validKeyConfig && !validAssumeRoleConfig {`
`88`		`- return errors.New("must have valid key pairs config or assume role config")`
	`87`	`+ validInstanceRoleConfig := option.AssumeRoleArn == "" && option.AssumeRegion == "" && option.SecretID == "" && option.SecretKey == ""`
	`88`	`+ if validKeyConfig \|\| validAssumeRoleConfig \|\| validInstanceRoleConfig {`
	`89`	`+ return nil`
`89`	`90`	`}`
`90`		`- return nil`
	`91`	`+ return errors.New("must have valid key pairs config or assume role config")`
`91`	`92`	`}`
`92`	`93`
`93`	`94`	`type CommonOption struct {`