Update BybitService.cs ctor: set url to HTTP_MAINNET_URL in case when null value is provided#9
Open
irene-displayr wants to merge 5 commits into
Open
Update BybitService.cs ctor: set url to HTTP_MAINNET_URL in case when null value is provided#9irene-displayr wants to merge 5 commits into
irene-displayr wants to merge 5 commits into
Conversation
…mp-type fixed type of timestamp parameter
fix asset withdraw timestamp issue
I've got an Exception when tried to use BybitMarketDataService without specifying url. If you look at the ctor from BybitMarketDataService you will notice that you set URL to default null in the ctor. That means that this "null" value will be passed all the way through to the BybitService, so your default value won't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got an Exception when tried to use BybitMarketDataService without specifying url.
If you look at the ctor from BybitMarketDataService you will notice that you set URL to default null in the ctor. That means that this "null" value will be passed all the way through to the BybitService, so your default value won't work.