always show livery name if no branding#359
Open
danielbrierley wants to merge 1 commit into
Open
Conversation
jclgoodwin
force-pushed
the
main
branch
3 times, most recently
from
33f45a2 to
4748f1f
Compare
Contributor
|
Good idea, would look nice on the smaller operators who do not add logos or anything so then it still says 'White' or whatever. |
jclgoodwin
force-pushed
the
main
branch
2 times, most recently
from
1a36e1e to
a01c5cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will make it so that if show_name is unticked, the livery name will only be hidden if there is branding present on the vehicle. If there is no branding, the livery name will still be shown.