[DIP] rotate2d operation may change picture size.

[taiqzheng]

Describe the bug
Image size change after rotation.

• input shape [1026, 1026]
• output shape [1028, 1028]

To Reproduce
After compiling the image-processing-rotate-benchmark benchmark. (rotate2d PR)
RUN:
./image-processing-rotate-benchmark ../../benchmarks/ImageProcessing/Images/YuTu.png RADIAN 1.57

Expected behavior
An output image with [1026, 1026].

Additional context
For comparing the similarity of Buddy & OpenCV rotation image, we need their result image with the same size.

[meshtag]

rotate_2d API is supposed to change the output image dimension by default. This is done for avoiding cutting off the edges in the rotated image. I think you can do some tricks to achieve the same effect with OpenCV's version as well.

As for this case of rotating the image with 90 degree, I agree that the output image must be of the same size as the input image (since num_rows = num_cols). Can you try giving a more accurate value of pi/2? (For ex. 1.570796)

[meshtag]

I tried putting in the more accurate value of pi/2 and got the output image dimensions as 1027x1027. This is because of the extra 1 I added here for taking care of out of bounds accesses. But I think we can remove that now since we have access control in the valBound function.

[meshtag]

@taiqzheng, this commit should ideally fix this problem. Can you please confirm if this works for you.

[taiqzheng]

Thanks!