Skip to content

security: harden publish workflow against Mini Shai-Hulud (pin + egress)#86

Merged
nmccready merged 1 commit into
mainfrom
security/shai-hulud-hardening
May 17, 2026
Merged

security: harden publish workflow against Mini Shai-Hulud (pin + egress)#86
nmccready merged 1 commit into
mainfrom
security/shai-hulud-hardening

Conversation

@nmccready
Copy link
Copy Markdown
Collaborator

Summary

Part of the Mini Shai-Hulud supply chain hardening campaign — closing OIDC hijack vectors in GitHub Actions publish pipelines across the brickhouse-tech org.

Changes

  • Pin brickhouse-tech/.github shared workflow ref from @main to SHA 3c0bca8e1e161a6f61aee72413611b6fca239974
  • Permissions (contents: read, id-token: write) already present at workflow level — verified and left intact

Threat model

Unpinned @main refs on shared workflows allow an attacker who pushes to the .github repo's main branch (or hijacks via OIDC) to inject arbitrary steps into every caller's publish run. Pinning to a SHA locks the caller to a known-good version.

Precedent

Same pattern already merged in:

Test plan

  • SHA 3c0bca8e1e161a6f61aee72413611b6fca239974 matches a reviewed commit on brickhouse-tech/.github
  • Publish workflow still triggers and delegates correctly to the shared workflow

@nmccready nmccready force-pushed the security/shai-hulud-hardening branch from 86d29e6 to 393a53f Compare May 13, 2026 21:43
@nmccready nmccready merged commit 86169b0 into main May 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant