From aeba9e8ee80f732eb5429cbf9680d52c273f456a Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Tue, 3 Mar 2026 19:53:54 +0000 Subject: [PATCH 1/2] Align readiness probe defaults with liveness Co-authored-by: Mike Deeks --- braintrust/tests/api-deployment_test.yaml | 12 ++++++++++++ braintrust/tests/brainstore-reader_test.yaml | 12 ++++++++++++ braintrust/tests/brainstore-writer_test.yaml | 12 ++++++++++++ braintrust/values.yaml | 18 +++++++++--------- 4 files changed, 45 insertions(+), 9 deletions(-) diff --git a/braintrust/tests/api-deployment_test.yaml b/braintrust/tests/api-deployment_test.yaml index 058c3e0..71b6a8a 100644 --- a/braintrust/tests/api-deployment_test.yaml +++ b/braintrust/tests/api-deployment_test.yaml @@ -22,6 +22,18 @@ tests: - equal: path: spec.template.spec.containers[0].imagePullPolicy value: IfNotPresent + - equal: + path: spec.template.spec.containers[0].livenessProbe.httpGet.path + value: / + - equal: + path: spec.template.spec.containers[0].livenessProbe.httpGet.port + value: 8000 + - equal: + path: spec.template.spec.containers[0].readinessProbe.httpGet.path + value: / + - equal: + path: spec.template.spec.containers[0].readinessProbe.httpGet.port + value: 8000 - it: should use correct namespace from helper when createNamespace is false values: diff --git a/braintrust/tests/brainstore-reader_test.yaml b/braintrust/tests/brainstore-reader_test.yaml index f9fe261..6f20077 100644 --- a/braintrust/tests/brainstore-reader_test.yaml +++ b/braintrust/tests/brainstore-reader_test.yaml @@ -22,6 +22,18 @@ tests: - equal: path: spec.template.spec.containers[0].image value: test/brainstore:v1.0.0 + - equal: + path: spec.template.spec.containers[0].livenessProbe.httpGet.path + value: / + - equal: + path: spec.template.spec.containers[0].livenessProbe.httpGet.port + value: 4000 + - equal: + path: spec.template.spec.containers[0].readinessProbe.httpGet.path + value: / + - equal: + path: spec.template.spec.containers[0].readinessProbe.httpGet.port + value: 4000 - it: should include azure workload identity label when cloud is azure values: diff --git a/braintrust/tests/brainstore-writer_test.yaml b/braintrust/tests/brainstore-writer_test.yaml index d6cff0d..3c3aed0 100644 --- a/braintrust/tests/brainstore-writer_test.yaml +++ b/braintrust/tests/brainstore-writer_test.yaml @@ -22,6 +22,18 @@ tests: - equal: path: spec.template.spec.containers[0].image value: test/brainstore:v1.0.0 + - equal: + path: spec.template.spec.containers[0].livenessProbe.httpGet.path + value: / + - equal: + path: spec.template.spec.containers[0].livenessProbe.httpGet.port + value: 4000 + - equal: + path: spec.template.spec.containers[0].readinessProbe.httpGet.path + value: / + - equal: + path: spec.template.spec.containers[0].readinessProbe.httpGet.port + value: 4000 - it: should include azure workload identity label when cloud is azure values: diff --git a/braintrust/values.yaml b/braintrust/values.yaml index adfe264..ea3b889 100644 --- a/braintrust/values.yaml +++ b/braintrust/values.yaml @@ -132,11 +132,11 @@ api: successThreshold: 1 readinessProbe: httpGet: - path: /status - port: 8001 - initialDelaySeconds: 10 - periodSeconds: 5 - timeoutSeconds: 3 + path: / + port: 8000 + initialDelaySeconds: 30 + periodSeconds: 10 + timeoutSeconds: 5 failureThreshold: 3 successThreshold: 1 # Health server configuration @@ -180,11 +180,11 @@ brainstore: successThreshold: 1 readinessProbe: httpGet: - path: /status + path: / port: 4000 - initialDelaySeconds: 30 - periodSeconds: 5 - timeoutSeconds: 3 + initialDelaySeconds: 60 + periodSeconds: 10 + timeoutSeconds: 5 failureThreshold: 3 successThreshold: 1 From caf3108925db0cc47ed48072a1869e89504609cc Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Tue, 3 Mar 2026 20:00:25 +0000 Subject: [PATCH 2/2] Remove probe default assertions from deployment tests Co-authored-by: Mike Deeks --- braintrust/tests/api-deployment_test.yaml | 12 ------------ braintrust/tests/brainstore-reader_test.yaml | 12 ------------ braintrust/tests/brainstore-writer_test.yaml | 12 ------------ 3 files changed, 36 deletions(-) diff --git a/braintrust/tests/api-deployment_test.yaml b/braintrust/tests/api-deployment_test.yaml index 71b6a8a..058c3e0 100644 --- a/braintrust/tests/api-deployment_test.yaml +++ b/braintrust/tests/api-deployment_test.yaml @@ -22,18 +22,6 @@ tests: - equal: path: spec.template.spec.containers[0].imagePullPolicy value: IfNotPresent - - equal: - path: spec.template.spec.containers[0].livenessProbe.httpGet.path - value: / - - equal: - path: spec.template.spec.containers[0].livenessProbe.httpGet.port - value: 8000 - - equal: - path: spec.template.spec.containers[0].readinessProbe.httpGet.path - value: / - - equal: - path: spec.template.spec.containers[0].readinessProbe.httpGet.port - value: 8000 - it: should use correct namespace from helper when createNamespace is false values: diff --git a/braintrust/tests/brainstore-reader_test.yaml b/braintrust/tests/brainstore-reader_test.yaml index 6f20077..f9fe261 100644 --- a/braintrust/tests/brainstore-reader_test.yaml +++ b/braintrust/tests/brainstore-reader_test.yaml @@ -22,18 +22,6 @@ tests: - equal: path: spec.template.spec.containers[0].image value: test/brainstore:v1.0.0 - - equal: - path: spec.template.spec.containers[0].livenessProbe.httpGet.path - value: / - - equal: - path: spec.template.spec.containers[0].livenessProbe.httpGet.port - value: 4000 - - equal: - path: spec.template.spec.containers[0].readinessProbe.httpGet.path - value: / - - equal: - path: spec.template.spec.containers[0].readinessProbe.httpGet.port - value: 4000 - it: should include azure workload identity label when cloud is azure values: diff --git a/braintrust/tests/brainstore-writer_test.yaml b/braintrust/tests/brainstore-writer_test.yaml index 3c3aed0..d6cff0d 100644 --- a/braintrust/tests/brainstore-writer_test.yaml +++ b/braintrust/tests/brainstore-writer_test.yaml @@ -22,18 +22,6 @@ tests: - equal: path: spec.template.spec.containers[0].image value: test/brainstore:v1.0.0 - - equal: - path: spec.template.spec.containers[0].livenessProbe.httpGet.path - value: / - - equal: - path: spec.template.spec.containers[0].livenessProbe.httpGet.port - value: 4000 - - equal: - path: spec.template.spec.containers[0].readinessProbe.httpGet.path - value: / - - equal: - path: spec.template.spec.containers[0].readinessProbe.httpGet.port - value: 4000 - it: should include azure workload identity label when cloud is azure values: