From 3f18d2f7121d9308d0c36a6d4d5d67f68dd6cdee Mon Sep 17 00:00:00 2001 From: Jeff McCollum Date: Wed, 11 Feb 2026 15:10:06 -0600 Subject: [PATCH 1/9] update env vars --- braintrust/templates/api-deployment.yaml | 5 +++++ braintrust/templates/brainstore-reader-deployment.yaml | 7 +++++++ braintrust/templates/brainstore-writer-deployment.yaml | 7 +++++++ 3 files changed, 19 insertions(+) diff --git a/braintrust/templates/api-deployment.yaml b/braintrust/templates/api-deployment.yaml index 7a440fc..176749c 100644 --- a/braintrust/templates/api-deployment.yaml +++ b/braintrust/templates/api-deployment.yaml @@ -85,6 +85,11 @@ spec: secretKeyRef: name: braintrust-secrets key: REDIS_URL + - name: REDIS_EPHEMERAL_WAL_URL + valueFrom: + secretKeyRef: + name: braintrust-secrets + key: REDIS_URL - name: FUNCTION_SECRET_KEY valueFrom: secretKeyRef: diff --git a/braintrust/templates/brainstore-reader-deployment.yaml b/braintrust/templates/brainstore-reader-deployment.yaml index 65b2a9c..7e905c9 100644 --- a/braintrust/templates/brainstore-reader-deployment.yaml +++ b/braintrust/templates/brainstore-reader-deployment.yaml @@ -107,6 +107,13 @@ spec: secretKeyRef: name: braintrust-secrets key: REDIS_URL + - name: BRAINSTORE_XACT_MANAGER_URI + valueFrom: + secretKeyRef: + name: braintrust-secrets + key: REDIS_URL + - name: BRAINSTORE_AI_PROXY_URL + value: "http://{{ .Values.api.service.name | default .Values.api.name }}:{{ .Values.api.service.port }}" {{- if eq .Values.brainstore.locksBackend "redis" }} - name: BRAINSTORE_LOCKS_URI valueFrom: diff --git a/braintrust/templates/brainstore-writer-deployment.yaml b/braintrust/templates/brainstore-writer-deployment.yaml index aadf86b..5866ea3 100644 --- a/braintrust/templates/brainstore-writer-deployment.yaml +++ b/braintrust/templates/brainstore-writer-deployment.yaml @@ -107,6 +107,13 @@ spec: secretKeyRef: name: braintrust-secrets key: REDIS_URL + - name: BRAINSTORE_XACT_MANAGER_URI + valueFrom: + secretKeyRef: + name: braintrust-secrets + key: REDIS_URL + - name: BRAINSTORE_AI_PROXY_URL + value: "http://{{ .Values.api.service.name | default .Values.api.name }}:{{ .Values.api.service.port }}" {{- if eq .Values.brainstore.locksBackend "redis" }} - name: BRAINSTORE_LOCKS_URI valueFrom: From 097ce31d7464052e23c25014cbfd6326b9f97977 Mon Sep 17 00:00:00 2001 From: Jeff McCollum Date: Wed, 11 Feb 2026 15:10:12 -0600 Subject: [PATCH 2/9] update tests --- braintrust/tests/api-deployment_test.yaml | 15 +++++++++++ braintrust/tests/brainstore-reader_test.yaml | 27 ++++++++++++++++++++ braintrust/tests/brainstore-writer_test.yaml | 27 ++++++++++++++++++++ 3 files changed, 69 insertions(+) diff --git a/braintrust/tests/api-deployment_test.yaml b/braintrust/tests/api-deployment_test.yaml index f495cd0..a6f36e2 100644 --- a/braintrust/tests/api-deployment_test.yaml +++ b/braintrust/tests/api-deployment_test.yaml @@ -239,3 +239,18 @@ tests: path: spec.template.spec.containers[0].livenessProbe - isNull: path: spec.template.spec.containers[0].readinessProbe + + - it: should include REDIS_EPHEMERAL_WAL_URL environment variable + values: + - __fixtures__/base-values.yaml + release: + namespace: "braintrust" + asserts: + - contains: + path: spec.template.spec.containers[0].env + content: + name: REDIS_EPHEMERAL_WAL_URL + valueFrom: + secretKeyRef: + name: braintrust-secrets + key: REDIS_URL diff --git a/braintrust/tests/brainstore-reader_test.yaml b/braintrust/tests/brainstore-reader_test.yaml index 4beacd1..9bab62d 100644 --- a/braintrust/tests/brainstore-reader_test.yaml +++ b/braintrust/tests/brainstore-reader_test.yaml @@ -203,3 +203,30 @@ tests: path: spec.template.spec.containers[0].livenessProbe - isNull: path: spec.template.spec.containers[0].readinessProbe + + - it: should include BRAINSTORE_XACT_MANAGER_URI environment variable + values: + - __fixtures__/base-values.yaml + release: + namespace: "braintrust" + asserts: + - contains: + path: spec.template.spec.containers[0].env + content: + name: BRAINSTORE_XACT_MANAGER_URI + valueFrom: + secretKeyRef: + name: braintrust-secrets + key: REDIS_URL + + - it: should include BRAINSTORE_AI_PROXY_URL environment variable + values: + - __fixtures__/base-values.yaml + release: + namespace: "braintrust" + asserts: + - contains: + path: spec.template.spec.containers[0].env + content: + name: BRAINSTORE_AI_PROXY_URL + value: "http://braintrust-api:8000" diff --git a/braintrust/tests/brainstore-writer_test.yaml b/braintrust/tests/brainstore-writer_test.yaml index d6af6d7..d6cff0d 100644 --- a/braintrust/tests/brainstore-writer_test.yaml +++ b/braintrust/tests/brainstore-writer_test.yaml @@ -203,3 +203,30 @@ tests: path: spec.template.spec.containers[0].livenessProbe - isNull: path: spec.template.spec.containers[0].readinessProbe + + - it: should include BRAINSTORE_XACT_MANAGER_URI environment variable + values: + - __fixtures__/base-values.yaml + release: + namespace: "braintrust" + asserts: + - contains: + path: spec.template.spec.containers[0].env + content: + name: BRAINSTORE_XACT_MANAGER_URI + valueFrom: + secretKeyRef: + name: braintrust-secrets + key: REDIS_URL + + - it: should include BRAINSTORE_AI_PROXY_URL environment variable + values: + - __fixtures__/base-values.yaml + release: + namespace: "braintrust" + asserts: + - contains: + path: spec.template.spec.containers[0].env + content: + name: BRAINSTORE_AI_PROXY_URL + value: "http://braintrust-api:8000" From e4f0065ca69d13ffb48c548c3c71c69e5af0af72 Mon Sep 17 00:00:00 2001 From: Jeff McCollum Date: Fri, 13 Feb 2026 10:39:35 -0600 Subject: [PATCH 3/9] update readme on v4 of helm --- braintrust/README.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/braintrust/README.md b/braintrust/README.md index bf3b4bb..babe3bf 100644 --- a/braintrust/README.md +++ b/braintrust/README.md @@ -158,8 +158,20 @@ This Helm chart includes comprehensive automated unit tests. ## Breaking Changes +### Version 2 + With version 2 of this helm, the Brainstore pods are split into Readers and Writers improving performance and the ability to independently scale for more read operations or write operations. For existing customers that have deployed our Helm or via other means on Kubernetes, please update your override values file or deployment to match this change. This will result in no data loss, but will be a brief downtime as the existing Brainstore Pods are removed and new Brainstore Pods for Reading and Writing are launched. +### Version 3 + +Breaking change only for Azure customers which introduced the Azure Container Storage CSI driver. + +### Version 4 + +This version of the Helm is in preparation of 2.0.0 of the Braintrust Self hosted Data Plane. Starting with 1.1.32 Brainstore will now need to reach out to the API, where before Brainstore didn't talk to the API. In Helm this is being done over the internal Kubernetes endpoint. If you have additional security restrictions or are limiting traffic between services, this will need to be allowed before upgrading to 2.0.0 of the data plane. + +We are also increasing the default sizing of our deployments, please ensure you have the node pool capacity for these increased defaults. + ## Example Values Files Example values files for different cloud providers and configurations are located in the `examples/` folder. From 88216c48c687a8216036430a7f0ac816907e669a Mon Sep 17 00:00:00 2001 From: Jeff McCollum Date: Fri, 13 Feb 2026 10:46:31 -0600 Subject: [PATCH 4/9] update default sizing --- braintrust/values.yaml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/braintrust/values.yaml b/braintrust/values.yaml index dd839d8..22d1ab5 100644 --- a/braintrust/values.yaml +++ b/braintrust/values.yaml @@ -78,7 +78,7 @@ api: service: {} pod: {} serviceaccount: {} - replicas: 2 + replicas: 4 image: repository: public.ecr.aws/braintrust/standalone-api tag: v1.1.31 @@ -204,11 +204,11 @@ brainstore: portName: http resources: requests: - cpu: "4" - memory: "8Gi" + cpu: "16" + memory: "32Gi" limits: - cpu: "8" - memory: "16Gi" + cpu: "20" + memory: "40Gi" cacheDir: "/mnt/tmp/brainstore" objectStoreCacheMemoryLimit: "1Gi" objectStoreCacheFileSize: "50Gi" @@ -241,11 +241,11 @@ brainstore: portName: http resources: requests: - cpu: "8" - memory: "16Gi" + cpu: "32" + memory: "64Gi" limits: - cpu: "16" - memory: "32Gi" + cpu: "40" + memory: "80Gi" cacheDir: "/mnt/tmp/brainstore" objectStoreCacheMemoryLimit: "1Gi" objectStoreCacheFileSize: "50Gi" From 8c9b011b41c690f2dc43024ae3b92d78a54b7c18 Mon Sep 17 00:00:00 2001 From: Jeff McCollum Date: Fri, 13 Feb 2026 12:21:34 -0600 Subject: [PATCH 5/9] add gke standard values example --- .../examples/google-standard/values.yaml | 144 ++++++++++++++++++ 1 file changed, 144 insertions(+) create mode 100644 braintrust/examples/google-standard/values.yaml diff --git a/braintrust/examples/google-standard/values.yaml b/braintrust/examples/google-standard/values.yaml new file mode 100644 index 0000000..cdd9a33 --- /dev/null +++ b/braintrust/examples/google-standard/values.yaml @@ -0,0 +1,144 @@ +# Sample values for GKE Standard deployment +# +# GKE Standard requires manual node pool configuration: +# - Create a dedicated node pool with local NVMe SSDs for Brainstore workloads +# - Recommended machine types: c4-standard-32 or higher with local SSDs +# - Configure local SSDs: Use 4x375GB local SSDs (1500GB total) or more +# - Total local SSD capacity should exceed the volume.size configured below + +# Global configs +global: + orgName: "" + namespace: "braintrust" + +# Cloud provider configuration +cloud: "google" + +# Google Cloud specific configuration for Standard +google: + mode: "standard" + +objectStorage: + google: + brainstoreBucket: "" + apiBucket: "" + +api: + name: "braintrust-api" + annotations: + service: + networking.gke.io/load-balancer-type: "Internal" + replicas: 4 + # Uncomment the following section to use a different image or tag from the version in the Helm release + #image: + #repository: public.ecr.aws/braintrust/standalone-api + #tag: "" + service: + type: LoadBalancer + port: 8000 + portName: http + serviceAccount: + name: "braintrust-api" + googleServiceAccount: "" + # this is for native GCS authentication via workload identity (defaults to false for S3-compatible access) Requires v1.1.31 or later of the dataplane to be set to true. + enableGcsAuth: false + nodeSelector: + cloud.google.com/gke-nodepool: "api" + resources: + requests: + cpu: "4" + memory: "4Gi" + limits: + cpu: "4" + memory: "8Gi" + extraEnvVars: + # For S3-compatible GCS Storage, set the AWS_REGION environment variable to the region of your GCS bucket + - name: AWS_REGION + value: "us-central1" + +# Brainstore configuration (split into reader and writer) +brainstore: + serviceAccount: + name: "brainstore" + googleServiceAccount: "" + # Uncomment the following section to use a different image or tag from the version in the Helm release + #image: + #repository: public.ecr.aws/braintrust/brainstore + #tag: "" + # New deployments should use objectStorage as the locks backend. Existing deployments should remain on redis at this time. + locksBackend: "objectStorage" + + # Brainstore Reader configuration + reader: + name: "brainstore-reader" + replicas: 2 + service: + name: "" + type: ClusterIP + port: 4000 + portName: http + nodeSelector: + cloud.google.com/gke-nodepool: "brainstore" # Target your node pool + resources: + requests: + cpu: "16" + memory: "32Gi" + limits: + cpu: "20" + memory: "40Gi" + affinity: # Prevent readers and writers from sharing nodes + podAntiAffinity: + requiredDuringSchedulingIgnoredDuringExecution: + - labelSelector: + matchExpressions: + - key: app + operator: In + values: + - brainstore-reader + - brainstore-writer + topologyKey: kubernetes.io/hostname + cacheDir: "/mnt/tmp/brainstore" + objectStoreCacheMemoryLimit: "1Gi" + objectStoreCacheFileSize: "100Gi" + verbose: true + volume: + size: "200Gi" + extraEnvVars: + + # Brainstore Writer configuration + writer: + name: "brainstore-writer" + replicas: 1 + service: + name: "" + type: ClusterIP + port: 4000 + portName: http + nodeSelector: + cloud.google.com/gke-nodepool: "brainstore" + resources: + requests: + cpu: "32" + memory: "64Gi" + limits: + cpu: "40" + memory: "80Gi" + affinity: # Prevent readers and writers from sharing nodes + podAntiAffinity: + requiredDuringSchedulingIgnoredDuringExecution: + - labelSelector: + matchExpressions: + - key: app + operator: In + values: + - brainstore-reader + - brainstore-writer + topologyKey: kubernetes.io/hostname + cacheDir: "/mnt/tmp/brainstore" + objectStoreCacheMemoryLimit: "1Gi" + objectStoreCacheFileSize: "100Gi" + verbose: true + volume: + size: "200Gi" + extraEnvVars: + \ No newline at end of file From aa6706e5326a13a6703af96ce5a0a31cea48b749 Mon Sep 17 00:00:00 2001 From: Jeff McCollum Date: Fri, 13 Feb 2026 12:21:48 -0600 Subject: [PATCH 6/9] spelling --- braintrust/examples/google-autopilot/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/braintrust/examples/google-autopilot/values.yaml b/braintrust/examples/google-autopilot/values.yaml index 6a0fe45..40d29f9 100644 --- a/braintrust/examples/google-autopilot/values.yaml +++ b/braintrust/examples/google-autopilot/values.yaml @@ -24,7 +24,7 @@ api: service: networking.gke.io/load-balancer-type: "Internal" replicas: 4 - # Uncomment the following section to use usee a different image or tag from the version in the Helm release + # Uncomment the following section to use a different image or tag from the version in the Helm release #image: #repository: public.ecr.aws/braintrust/standalone-api #tag: "" From a382fa60cbdbac1904658681c4467dc7f933b280 Mon Sep 17 00:00:00 2001 From: Jeff McCollum Date: Fri, 13 Feb 2026 12:45:46 -0600 Subject: [PATCH 7/9] update values --- braintrust/examples/google-autopilot/values.yaml | 12 ++++++------ braintrust/examples/google-standard/values.yaml | 12 ++++++------ braintrust/values.yaml | 12 ++++++------ 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/braintrust/examples/google-autopilot/values.yaml b/braintrust/examples/google-autopilot/values.yaml index 40d29f9..3865408 100644 --- a/braintrust/examples/google-autopilot/values.yaml +++ b/braintrust/examples/google-autopilot/values.yaml @@ -75,11 +75,11 @@ brainstore: cpu: "16" memory: "32Gi" limits: - cpu: "20" - memory: "40Gi" + cpu: "16" + memory: "32Gi" cacheDir: "/mnt/tmp/brainstore" objectStoreCacheMemoryLimit: "1Gi" - objectStoreCacheFileSize: "100Gi" + objectStoreCacheFileSize: "1000Gi" verbose: true volume: size: "200Gi" @@ -99,11 +99,11 @@ brainstore: cpu: "32" memory: "64Gi" limits: - cpu: "40" - memory: "80Gi" + cpu: "32" + memory: "64Gi" cacheDir: "/mnt/tmp/brainstore" objectStoreCacheMemoryLimit: "1Gi" - objectStoreCacheFileSize: "100Gi" + objectStoreCacheFileSize: "1000Gi" verbose: true volume: size: "200Gi" diff --git a/braintrust/examples/google-standard/values.yaml b/braintrust/examples/google-standard/values.yaml index cdd9a33..2717bda 100644 --- a/braintrust/examples/google-standard/values.yaml +++ b/braintrust/examples/google-standard/values.yaml @@ -84,8 +84,8 @@ brainstore: cpu: "16" memory: "32Gi" limits: - cpu: "20" - memory: "40Gi" + cpu: "16" + memory: "32Gi" affinity: # Prevent readers and writers from sharing nodes podAntiAffinity: requiredDuringSchedulingIgnoredDuringExecution: @@ -99,7 +99,7 @@ brainstore: topologyKey: kubernetes.io/hostname cacheDir: "/mnt/tmp/brainstore" objectStoreCacheMemoryLimit: "1Gi" - objectStoreCacheFileSize: "100Gi" + objectStoreCacheFileSize: "1000Gi" verbose: true volume: size: "200Gi" @@ -121,8 +121,8 @@ brainstore: cpu: "32" memory: "64Gi" limits: - cpu: "40" - memory: "80Gi" + cpu: "32" + memory: "64Gi" affinity: # Prevent readers and writers from sharing nodes podAntiAffinity: requiredDuringSchedulingIgnoredDuringExecution: @@ -136,7 +136,7 @@ brainstore: topologyKey: kubernetes.io/hostname cacheDir: "/mnt/tmp/brainstore" objectStoreCacheMemoryLimit: "1Gi" - objectStoreCacheFileSize: "100Gi" + objectStoreCacheFileSize: "1000Gi" verbose: true volume: size: "200Gi" diff --git a/braintrust/values.yaml b/braintrust/values.yaml index 22d1ab5..6dc8dd1 100644 --- a/braintrust/values.yaml +++ b/braintrust/values.yaml @@ -207,11 +207,11 @@ brainstore: cpu: "16" memory: "32Gi" limits: - cpu: "20" - memory: "40Gi" + cpu: "16" + memory: "32Gi" cacheDir: "/mnt/tmp/brainstore" objectStoreCacheMemoryLimit: "1Gi" - objectStoreCacheFileSize: "50Gi" + objectStoreCacheFileSize: "1000Gi" verbose: true # Optional: Volume configuration for cache storage # When not set, uses default emptyDir: {} (backward compatible) @@ -244,11 +244,11 @@ brainstore: cpu: "32" memory: "64Gi" limits: - cpu: "40" - memory: "80Gi" + cpu: "32" + memory: "64Gi" cacheDir: "/mnt/tmp/brainstore" objectStoreCacheMemoryLimit: "1Gi" - objectStoreCacheFileSize: "50Gi" + objectStoreCacheFileSize: "1000Gi" verbose: true # Optional: Volume configuration for cache storage # When not set, uses default emptyDir: {} (backward compatible) From 8f5070a3a620a190b177f61b4e859fe7ee1c0284 Mon Sep 17 00:00:00 2001 From: Jeff McCollum Date: Fri, 13 Feb 2026 14:05:01 -0600 Subject: [PATCH 8/9] remove REDIS_EPHEMERAL_WAL_URL add BRAINSTORE_REALTIME_WAL_BUCKET_NAME --- braintrust/templates/api-configmap.yaml | 3 +++ braintrust/templates/api-deployment.yaml | 5 ----- braintrust/tests/api-configmap_test.yaml | 9 +++++++++ braintrust/tests/api-deployment_test.yaml | 15 --------------- 4 files changed, 12 insertions(+), 20 deletions(-) diff --git a/braintrust/templates/api-configmap.yaml b/braintrust/templates/api-configmap.yaml index 8c40187..533f0fc 100644 --- a/braintrust/templates/api-configmap.yaml +++ b/braintrust/templates/api-configmap.yaml @@ -21,16 +21,19 @@ data: CODE_BUNDLE_BUCKET: {{ .Values.objectStorage.azure.codeBundleContainer | quote }} BRAINSTORE_REALTIME_WAL_BUCKET: {{ .Values.objectStorage.azure.brainstoreContainer | quote }} BRAINSTORE_REALTIME_WAL_BUCKET_PREFIX: "brainstore/wal" + BRAINSTORE_REALTIME_WAL_BUCKET_NAME: "az://{{ .Values.objectStorage.azure.brainstoreContainer }}/brainstore/wal" {{- else if eq .Values.cloud "aws" }} RESPONSE_BUCKET: {{ .Values.objectStorage.aws.responseBucket | quote }} CODE_BUNDLE_BUCKET: {{ .Values.objectStorage.aws.codeBundleBucket | quote }} BRAINSTORE_REALTIME_WAL_BUCKET: {{ .Values.objectStorage.aws.brainstoreBucket | quote }} + BRAINSTORE_REALTIME_WAL_BUCKET_NAME: "s3://{{ .Values.objectStorage.aws.brainstoreBucket }}/brainstore/wal" {{- else if eq .Values.cloud "google" }} RESPONSE_BUCKET: {{ .Values.objectStorage.google.apiBucket | quote }} RESPONSE_BUCKET_PREFIX: "response/" CODE_BUNDLE_BUCKET: {{ .Values.objectStorage.google.apiBucket | quote }} CODE_BUNDLE_BUCKET_PREFIX: "code-bundle/" BRAINSTORE_REALTIME_WAL_BUCKET: {{ .Values.objectStorage.google.brainstoreBucket | quote }} + BRAINSTORE_REALTIME_WAL_BUCKET_NAME: "gs://{{ .Values.objectStorage.google.brainstoreBucket }}/brainstore/wal" {{- if .Values.api.enableGcsAuth }} ENABLE_GCS_AUTH: "true" {{- else }} diff --git a/braintrust/templates/api-deployment.yaml b/braintrust/templates/api-deployment.yaml index 176749c..7a440fc 100644 --- a/braintrust/templates/api-deployment.yaml +++ b/braintrust/templates/api-deployment.yaml @@ -85,11 +85,6 @@ spec: secretKeyRef: name: braintrust-secrets key: REDIS_URL - - name: REDIS_EPHEMERAL_WAL_URL - valueFrom: - secretKeyRef: - name: braintrust-secrets - key: REDIS_URL - name: FUNCTION_SECRET_KEY valueFrom: secretKeyRef: diff --git a/braintrust/tests/api-configmap_test.yaml b/braintrust/tests/api-configmap_test.yaml index 5d206bd..61a4047 100644 --- a/braintrust/tests/api-configmap_test.yaml +++ b/braintrust/tests/api-configmap_test.yaml @@ -65,6 +65,9 @@ tests: - equal: path: data.BRAINSTORE_REALTIME_WAL_BUCKET value: "test-brainstore-bucket" + - equal: + path: data.BRAINSTORE_REALTIME_WAL_BUCKET_NAME + value: "s3://test-brainstore-bucket/brainstore/wal" - it: should configure Azure storage when cloud is azure values: @@ -88,6 +91,9 @@ tests: - equal: path: data.BRAINSTORE_REALTIME_WAL_BUCKET_PREFIX value: "brainstore/wal" + - equal: + path: data.BRAINSTORE_REALTIME_WAL_BUCKET_NAME + value: "az://brainstore/brainstore/wal" - it: should configure Google Cloud buckets when cloud is google values: @@ -111,6 +117,9 @@ tests: - equal: path: data.BRAINSTORE_REALTIME_WAL_BUCKET value: "test-brainstore-bucket" + - equal: + path: data.BRAINSTORE_REALTIME_WAL_BUCKET_NAME + value: "gs://test-brainstore-bucket/brainstore/wal" - equal: path: data.AWS_ENDPOINT_URL value: "https://storage.googleapis.com" diff --git a/braintrust/tests/api-deployment_test.yaml b/braintrust/tests/api-deployment_test.yaml index a6f36e2..f495cd0 100644 --- a/braintrust/tests/api-deployment_test.yaml +++ b/braintrust/tests/api-deployment_test.yaml @@ -239,18 +239,3 @@ tests: path: spec.template.spec.containers[0].livenessProbe - isNull: path: spec.template.spec.containers[0].readinessProbe - - - it: should include REDIS_EPHEMERAL_WAL_URL environment variable - values: - - __fixtures__/base-values.yaml - release: - namespace: "braintrust" - asserts: - - contains: - path: spec.template.spec.containers[0].env - content: - name: REDIS_EPHEMERAL_WAL_URL - valueFrom: - secretKeyRef: - name: braintrust-secrets - key: REDIS_URL From 8401e6c980927fe4911116b08c1837eb5af7aee1 Mon Sep 17 00:00:00 2001 From: Jeff McCollum Date: Fri, 13 Feb 2026 14:21:31 -0600 Subject: [PATCH 9/9] remove BRAINSTORE_REALTIME_WAL_BUCKET_NAME --- braintrust/templates/api-configmap.yaml | 3 --- braintrust/tests/api-configmap_test.yaml | 9 --------- 2 files changed, 12 deletions(-) diff --git a/braintrust/templates/api-configmap.yaml b/braintrust/templates/api-configmap.yaml index 533f0fc..8c40187 100644 --- a/braintrust/templates/api-configmap.yaml +++ b/braintrust/templates/api-configmap.yaml @@ -21,19 +21,16 @@ data: CODE_BUNDLE_BUCKET: {{ .Values.objectStorage.azure.codeBundleContainer | quote }} BRAINSTORE_REALTIME_WAL_BUCKET: {{ .Values.objectStorage.azure.brainstoreContainer | quote }} BRAINSTORE_REALTIME_WAL_BUCKET_PREFIX: "brainstore/wal" - BRAINSTORE_REALTIME_WAL_BUCKET_NAME: "az://{{ .Values.objectStorage.azure.brainstoreContainer }}/brainstore/wal" {{- else if eq .Values.cloud "aws" }} RESPONSE_BUCKET: {{ .Values.objectStorage.aws.responseBucket | quote }} CODE_BUNDLE_BUCKET: {{ .Values.objectStorage.aws.codeBundleBucket | quote }} BRAINSTORE_REALTIME_WAL_BUCKET: {{ .Values.objectStorage.aws.brainstoreBucket | quote }} - BRAINSTORE_REALTIME_WAL_BUCKET_NAME: "s3://{{ .Values.objectStorage.aws.brainstoreBucket }}/brainstore/wal" {{- else if eq .Values.cloud "google" }} RESPONSE_BUCKET: {{ .Values.objectStorage.google.apiBucket | quote }} RESPONSE_BUCKET_PREFIX: "response/" CODE_BUNDLE_BUCKET: {{ .Values.objectStorage.google.apiBucket | quote }} CODE_BUNDLE_BUCKET_PREFIX: "code-bundle/" BRAINSTORE_REALTIME_WAL_BUCKET: {{ .Values.objectStorage.google.brainstoreBucket | quote }} - BRAINSTORE_REALTIME_WAL_BUCKET_NAME: "gs://{{ .Values.objectStorage.google.brainstoreBucket }}/brainstore/wal" {{- if .Values.api.enableGcsAuth }} ENABLE_GCS_AUTH: "true" {{- else }} diff --git a/braintrust/tests/api-configmap_test.yaml b/braintrust/tests/api-configmap_test.yaml index 61a4047..5d206bd 100644 --- a/braintrust/tests/api-configmap_test.yaml +++ b/braintrust/tests/api-configmap_test.yaml @@ -65,9 +65,6 @@ tests: - equal: path: data.BRAINSTORE_REALTIME_WAL_BUCKET value: "test-brainstore-bucket" - - equal: - path: data.BRAINSTORE_REALTIME_WAL_BUCKET_NAME - value: "s3://test-brainstore-bucket/brainstore/wal" - it: should configure Azure storage when cloud is azure values: @@ -91,9 +88,6 @@ tests: - equal: path: data.BRAINSTORE_REALTIME_WAL_BUCKET_PREFIX value: "brainstore/wal" - - equal: - path: data.BRAINSTORE_REALTIME_WAL_BUCKET_NAME - value: "az://brainstore/brainstore/wal" - it: should configure Google Cloud buckets when cloud is google values: @@ -117,9 +111,6 @@ tests: - equal: path: data.BRAINSTORE_REALTIME_WAL_BUCKET value: "test-brainstore-bucket" - - equal: - path: data.BRAINSTORE_REALTIME_WAL_BUCKET_NAME - value: "gs://test-brainstore-bucket/brainstore/wal" - equal: path: data.AWS_ENDPOINT_URL value: "https://storage.googleapis.com"