-
Notifications
You must be signed in to change notification settings - Fork 235
fix(cli): extend SQUAD_TEAM_ROOT to all resolveSquad() call sites #835
Copy link
Copy link
Closed
jazz127/squaddev
#4Description
Follow-up from PR #763 (Amanda Silver)
PR #763 wired SQUAD_TEAM_ROOT into nap, status, and cost commands. However, other commands that call resolveSquad(process.cwd()) may also break in subprocess contexts.
Action Items
- Audit all
resolveSquad()call sites — find every place that passesprocess.cwd()and evaluate if it should usegetSquadStartDir()instead - Commands to check:
init,upgrade,doctor,watch,loop, and any other command that resolves the squad directory - Add integration test: Verify all commands work when
SQUAD_TEAM_ROOTis set to a different directory thanprocess.cwd()
Context
getSquadStartDir()returnsprocess.env['SQUAD_TEAM_ROOT'] || process.cwd()- Currently only 3 of N commands use it
- Subprocess contexts (Copilot CLI bang commands, CI pipelines, watch dispatches) all hit this
Related
- PR fix(cli): wire SQUAD_TEAM_ROOT into squad resolution for subprocess compatibility (#734) #763 — initial fix for nap/status/cost
- Issue bug: squad nap fails when invoked via bang command (!) in Windows PowerShell terminal #734 — original bug report
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels