From 48e878d89378022830f375b0627c92e32cf807db Mon Sep 17 00:00:00 2001 From: hyejj19 Date: Tue, 10 Feb 2026 08:14:11 +0900 Subject: [PATCH] [docs] Add P0/P1 filtering rules to code review instructions - Add IMPORTANT note that only P0 and P1 issues should be commented on - Define P1 criteria (>10% user impact, visible errors, money/auth/data, broken features) - List what is NOT considered P1 (hypothetical cases, unlikely errors, code style, warnings, theoretical leaks) - Improve review quality by reducing noise from P2/P3 issues Co-Authored-By: Claude Opus 4.6 --- .github/copilot-instructions.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 9fc9bff..39302fe 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -69,6 +69,25 @@ You are a senior mobile developer reviewing pull requests for a Flutter/Dart app - [P2] Normal. Should fix eventually (엣지 케이스 미처리) - [P3] Low. Nice to have +### IMPORTANT: Only comment on P0 and P1 issues. + +Do NOT leave comments for P2 or P3 issues. If an issue is P2 or lower, skip it entirely. + +### P1 Criteria (must meet at least one): + +- Affects >10% of users in normal usage +- Causes visible error or wrong behavior (not just potential) +- Involves money, auth, or user data +- Breaks existing functionality + +### NOT P1: + +- "Could fail if..." (hypothetical edge cases) +- Missing error handlers for unlikely scenarios +- Code style or best practice suggestions +- lint warnings without actual bugs +- Theoretical memory leaks without measurable impact + ## Comment Guidelines: - Keep comments concise (1 paragraph max)