MakeColor(clMaroon) make a GRAYSCALE color

[AndrewBJ]

The problem with a clMaroon parameter which is TColor but a function (AGrayScale : Byte) called

function  MakeColor( AColor : TColor ) : TAlphaColor; overload;
function  MakeColor( AGrayScale : Byte ) : TAlphaColor; overload;

I think a grayscale functions should have a different name

[bmitov]

Thank you! What name you would propose? I have not had issues with the function name, but open to suggestions :-)

[AndrewBJ]

there is already a function
function MakeGrayScaleColor( AAlpha : Byte; AColor : Byte ) : TAlphaColor;
I think this particular function can be overloaded by the version without the Alpha parameter

[AndrewBJ]

Hi. Check a pullrequest please. Fixed a work with sets (critical) and grayscale conversion functions naming