Trying to get Apollo 3 compat working - feedback appreciated

[onpaws]

Was experimenting with upgrading this project (nice work btw) to Apollo 3, and noticed there is apparently a change in Apollo 3's apollo-link which breaks the current version of apollo-link-refresh-token (0.2.7 at the time of writing).

I see apollo-link-token-refresh relies on Apollo v2's operation.toKey(), and since Apollo 3 has dropped this (version 2, version 3) a workaround is needed.

I happened to see apollo-link's test mocks seem to generate keys based on request and tried to re-purpose that helper function to fix things.

Well, I was able to get TypeScript happy again, but I'm not sure if this is actually a good idea.
I'm curious your opinion! What do you think?

I believe the point of the key is that it should be unique - not 100% sure if this actually guarantees that.

PR - strictly a WIP
Fork
Docs on stateful links

[benawad]

I don't know much about the internals of Apollo, but that seems fine to me

[onpaws]

Was just informed of another effort to get 3.0 support, and now I'm starting to suspect rolling my own toKey might not ultimately be the right way to go.

The problem was that the queue system was calling toKey which was removed as unreliable.
newsiberian/apollo-link-token-refresh#15 (comment)

I hadn't seen this before opening my PR. So now I'm thinking I might try and port the revised solution to TypeScript since that's what my project is written in.

[onpaws]

I'm curious Ben, have you seen this?

For example, when using some form of token based authentication, there is a need to handle re-authentication when the token expires.

Isn't this exactly why we're using apollo-link-token-refresh?

Today I timeboxed 20-30 minutes starting with their sample code and trying to accomplish setting up the refresh, but haven't yet managed. Seems to me it'd be cool to avoid the 3rd party dep if possible. What do you think?

[benawad]

yeah that would probably work

[onpaws]

FYI I updated apollo-link-refresh-token for Apollo 3.0.

Tentatively things seem to be working great so far, feedback appreciated if you have time.

[JEGardner]

@onpaws I got it working with your branch of apollo-link-refresh-token, thanks!

[onpaws]

Brilliant! Thanks for the update @JEGardner 👍

[onpaws]

FYI my PR got merged upstream and published to NPM. Meanwhile Apollo 3 is at rc2 so for folks looking to upgrade, the situation is getting more interesting.

[onpaws]

FYI, this still works with the 3.0.0 final release that came out earlier this week.