-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Hey! I saw your latest changes, and this starts to be a awsome runner!! I'm impressed.
However I found bugs!
- Suite.js. _getReport() function. You are getting the report error from
this._err;but this doesn't exist, and are not used inside the code? Same thing for hook.js - addReporter() functions are never invoked.
- There is a difference between the Test and Hook in the assert module, so when you are calling the failure assert,
this._test._validateFailureit doesn't exist for the Hook. - skip and only doesn't show up in the reporter output
- The Count assert. Try to run without a number. Infinity loop and hang.
- Throws assert should maybe accept regExp?
- Your event handling seems to be broken and / or not completed yet
- failed tests are marked red together with the stack traces (also red color). Hard too sread what's going on. And the stack trace red color hard to read too. And what about making the stack trace info more logic?
Not a bug, but after looking at AVA and tape source. Why are you passing this from Suite to test, and not keeping this functions within the test module?
Quick question. Why need for a new Runner prototype for the reporter? And how are you going to add in different reporters?
Metadata
Metadata
Assignees
Labels
No labels